-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reencoding video is failing on studio.blender.org_en_open-movies #386
Comments
I've followed the steps mentioned above, here are my observations - Specific video causing the problem - Q) Why this specific video is causing a problem? And that's why libvorbis audio encoder struggles to encode 5.1 channel audio at a very low Solutions: (all tested)
|
Thank you @Rancho-rachit for the great analysis and the great solutions proposed I'm biased towards setting |
I've watched the short, there is no audio effect warranting the extra volume. |
My question is not for this specific video for both all videos of all scrapers who reencode the videos with standard scrapers settings (youtube and ted ATM) |
Educational content is pretty light as far as sound effects go, we should be fine with standards settings. |
I don't know what standards settings are. Let me rephrase my original question: we currently do not mind about the number of audio channels in our videos while reencoding. This causes the side-effect that when the source has too many channel, e.g. 5.1 but could be anything else, reencoding to our settings (libvorbis with audio bitrate of 48kbps max) fails (impossible to respect this limit with so many channels). We probably do not want to increase the max bitrate because we want to keep video size as small as possible (at least in low settings). We can set the number of audio channels to use. We have the choice between 1 or 2 channels. 1 channel means mono sound, forcing the encoder to mux stereo and more channels into a single one. This is my preference because it helps to keep ZIM size small. 2 channels means that even for videos which are mono at the source we will "fake/upmix" to stereo channels. Hence my original question: do we agree that we should force mono sound on all our reencoded videos? This morning I did some tests and they are not conclusive at all. Mono videos regularly takes more space than stereo ones. And resulting sound is ... very comparable. I hence propose to always force stereo, since it is probably the best compromise in terms of size and quality. |
yes |
I also ran some tests and noticed that even if a video originally had mono channel audio preprocessing, re-encoding it with stereo audio reduced its size by about 5% while maintaining similar quality. |
Thank you, closing this in favor of openzim/python-scraperlib#250, I will hopefully do and release this today or early next week, and then release youtube as well. |
In fact, let's keep this open until upstream issue is fixed and merged into this scraper. |
See openzim/zim-requests#1261 for details.
Looks like a specific video has issue with audio reencoding.
One should try to:
VideoWebmHigh
presets (https://github.com/openzim/python-scraperlib/blob/1afacffad3a66bd87cee8d4702ca95d498b3b645/src/zimscraperlib/video/presets.py#L83-L104)The text was updated successfully, but these errors were encountered: