Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zimit 2 tests: 100rabbits #1011

Open
benoit74 opened this issue May 28, 2024 · 14 comments
Open

Zimit 2 tests: 100rabbits #1011

benoit74 opened this issue May 28, 2024 · 14 comments
Assignees

Comments

@benoit74
Copy link
Contributor

benoit74 commented May 28, 2024

A new Zimit2 ZIM is ready for testing (really ready this time, I hope at least ^^)

Scraper: warc2zim 2.0.0-dev8 + zimit 2.0.0-dev5 + Browsertrix crawler 1.1.3
ZIM: https://mirror.download.kiwix.org/zim/.hidden/dev/100rabbits_en_2024-05.zim
Library link: https://dev.library.kiwix.org/viewer#100rabbits_en_2024-05/

Suggested test plan:

  • Open the ZIM, check homepage and 5 subpages (randomly chosen) loads properly
  • Perform a suggestion search and open any suggestion
  • Perform a full-text search, check result quality and open any result
  • Open the "Orca" page (link on the left menu) and confirm Youtube video plays correctly (audio + video)

@Jaifroid I can't assign you since you've never contributed to this repo, but you are more than welcomed to test as well ^^

@Jaifroid
Copy link
Collaborator

Thanks, @benoit74, I'll test on PWA and Browser Extension.

@Popolechien
Copy link
Collaborator

@benoit74 I think you got the library link wrong (it's mesquartierschinois instead of 100 rabbits)

@Popolechien
Copy link
Collaborator

Tested on macOS, works like a charm.
Works also on Android (3.10.1) but not the Orca video (I get a black screen).

@benoit74
Copy link
Contributor Author

@benoit74 I think you got the library link wrong (it's mesquartierschinois instead of 100 rabbits)

Yup, fixed library link.

Works also on Android (3.10.1) but not the Orca video (I get a black screen).

😫

@Jaifroid
Copy link
Collaborator

Jaifroid commented May 28, 2024

Orca video is broken on Chromium browsers, even in Kiwix Serve and in the PWA. It works in Firefox.

Go to this page in a Chromium browser: https://dev.library.kiwix.org/viewer#100rabbits_en_2024-05/100r.co/site/orca.html . Same for the video on the DotGrid page: https://dev.library.kiwix.org/viewer#100rabbits_en_2024-05/100r.co/site/dotgrid.html.

Tested on Chrome and Edge for Windows. Works on Firefox for Windows.

I re-tested 100rabbits_en_2024-02.zim for comparison, and the videos work on Chromium browsers there, so this appears to be a regression with this test ZIM. 🤔🥲 (Sorry...)

Screenshot of the issue and the error message (in Wombat) on Kiwix JS Browser Extension:

image

@Jaifroid
Copy link
Collaborator

On the positive side, everything else seems to work well! 💐

@Jaifroid
Copy link
Collaborator

Further info: the video works in the Firefox PWA on Android, but not in the Chrome (system) browser PWA. This confirms it's not an Android issue at all, but a specific issue with the rewriting in Chromium browsers across all platforms (I suppose, at least Windows and Android). (I also added a screenshot of the error shown in console in comment above).

@benoit74
Copy link
Contributor Author

Thank you all! It's quite positive the issue is reproducible on probably all Chromium browsers, it means it is not tight to a specific mobile device reader AND much easier to debug on my machine ^^ Might be related to some recent YouTube change in the player to optimize something on Chromium

@benoit74
Copy link
Contributor Author

Issue and fix found ... quite weird indeed but 🤷🏻

@benoit74
Copy link
Contributor Author

I've just uploaded a new version of the ZIM, supposed to repair broken stuff. Same links.

As far as I can tell, it still has an issue with Kiwix Android but seems to now work on all Chromium-based readers. Could you please all confirm?

@Popolechien
Copy link
Collaborator

MacOS and Kiwix-JS Chrome are ok!

@Jaifroid
Copy link
Collaborator

I additionally confirm that video (both Orca and Dotgrid) is now working in:

  • PWA on Chrome desktop
  • PWA on Chrome for Android
  • Browser Extension on Firefox desktop (Popolechien tested it in Chrome extension)

In PWA on iPad and PWA on iPhone (Safari), the Orca video isn't working. If it's working in the iOS app but not in Safari, then that's a bit puzzling, given that mesquartierschinois was displaying similar video issues on iOS app and PWA. Should perhaps be double-checked that mesquartierschinois video is not working on the iOS app.

@benoit74
Copy link
Contributor Author

In PWA on iPad and PWA on iPhone (Safari), the Orca video isn't working.

This is a PWA on Safari issue for me. Triggered by Youtube player in zimit2 ZIM, but this is a "detail". See kiwix/kiwix-js#1256 again

@Jaifroid
Copy link
Collaborator

This is a PWA on Safari issue for me. Triggered by Youtube player in zimit2 ZIM, but this is a "detail". See kiwix/kiwix-js#1256 again

I confirm. The good thing to know is that video does work on iOS (iPad and iPhone) when the ZIM is served from Kiwix Serve. That's great news for Zimit 2 overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants