Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to access updated helm-only and operator-only values in post-hook interface. #61

Open
anmol372 opened this issue Oct 6, 2020 · 0 comments
Assignees
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone

Comments

@anmol372
Copy link
Contributor

anmol372 commented Oct 6, 2020

The values are available in a segregated fashion for the Post-Hook interface, which makes it difficult to keep track of updates to the CR.

The values are available at:

  1. release.Config: Only updated if the helm release is affected
  2. release.Chart.Values: Only contains the values of the helm-chart at the time of change in helm-release.
  3. obj *unstructured.Unstructured: This map contains a key "spec", with updated values, including some 'operator-only' that do not affect the release.

The process of using updated values is much simpler for Pre-Hooks, they are provided with a map of all three values, and Override values coalesced into a single place.

@varshaprasad96 varshaprasad96 self-assigned this Nov 16, 2021
@varshaprasad96 varshaprasad96 added this to the Next milestone Nov 30, 2021
@everettraven everettraven added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

3 participants