Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotless plugin activation issue #2697

Open
csviri opened this issue Feb 22, 2025 · 3 comments · May be fixed by #2704
Open

Spotless plugin activation issue #2697

csviri opened this issue Feb 22, 2025 · 3 comments · May be fixed by #2704
Assignees

Comments

@csviri
Copy link
Collaborator

csviri commented Feb 22, 2025

Now the spotless plugin does not activates on main.
It was moved recently under a profile that should activate for the rood dir only:

 <profile>
      <id>spotless</id>
      <activation>
        <file>
          <exists>contributing</exists>
        </file>
      </activation>
      <build>
        <plugins>
          <plugin>
            <groupId>com.diffplug.spotless</groupId>
            <artifactId>spotless-maven-plugin</artifactId>
            <configuration>
              <pom>

 ...rest omitted  

But even if I run explicitly mvn spotless:apply it does not reformat code. Check is not working either
that is why PRs are not catching this issue (./mvnw ${MAVEN_ARGS} spotless:check --file pom.xml )

@csviri
Copy link
Collaborator Author

csviri commented Feb 22, 2025

@xstefank would you be able to take a look pls? we can also temporarily revert this.

@xstefank
Copy link
Collaborator

@csviri I'll take a look, but I'm after wisdom teeth removal, so as soon as I can.

@csviri
Copy link
Collaborator Author

csviri commented Feb 22, 2025

@xstefank sure no hurry, might to some temporal revert for practical reasons. thank you!!

@xstefank xstefank linked a pull request Feb 25, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants