Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to dismiss Danger Dialog should read Cancel #225

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

myabc
Copy link

@myabc myabc commented Jan 14, 2025

What are you trying to accomplish?

Correct a mistake in the implementation. The original Acceptance Criteria specified "Cancel" as button text:

https://community.openproject.org/projects/openproject/work_packages/58680/activity#acceptance-criteria

Screenshots

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

This corrects a mistake in the implementation. The original Acceptance
Criteria specified "Cancel" as button text:

https://community.openproject.org/projects/openproject/work_packages/58680/activity#acceptance-criteria
Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 6ae694b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@myabc myabc requested a review from HDinger January 14, 2025 15:58
@HDinger HDinger merged commit 198763d into main Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants