Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings component is not reacting on updates #106

Open
NilsJacobsen opened this issue Jul 3, 2024 — with Linear · 1 comment
Open

settings component is not reacting on updates #106

NilsJacobsen opened this issue Jul 3, 2024 — with Linear · 1 comment
Assignees

Comments

Copy link
Member

Screen_Recording_2024-07-03_at_09.25.55.mov

@NilsJacobsen NilsJacobsen added the Improvement label Jul 3, 2024 — with Linear
@NilsJacobsen NilsJacobsen self-assigned this Jul 3, 2024
Copy link
Member Author

We have a similar challenge, comparable with the message bundle component: We want to revert changes. In the settings rn it is solved like that:

  • when a component gets loaded, it writes the settings in a new settings object.
  • Updates happen now on this object
  • Until now, it wasn't required to react to changes, so it was possible to get back to the inserted state.

Problem: To react to changes, we must override new settings every time the component receives an update. Now, we lose track of the latest saved state. Without access to history, this is not solvable without a hack.

-> @martin.lysk1, you talked about adding a "lastPushed" prop to the messageBundle? Are you any further in the discussion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant