Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak tests are currently skipped #1346

Open
IdoZilberberg opened this issue Sep 25, 2019 · 1 comment
Open

Memory leak tests are currently skipped #1346

IdoZilberberg opened this issue Sep 25, 2019 · 1 comment

Comments

@IdoZilberberg
Copy link
Contributor

* paste test failure summary here (copy from CI) *
Condition failed!
        	Test:       	TestMemoryLeaks_DuringRuntime
        	Messages:   	Heap size increased too much during runtime.
        	            	Pre-run: 19907640 bytes, during-run: 23072440 bytes, added 3164800 bytes. 
        	            	This is more than 10% of initial memory and more than the allowed addition of 1048576 bytes. 
        	            	Compare /home/circleci/project/_out/memory_leaks/mem-runtime-before.prof and /home/circleci/project/_out/memory_leaks/mem-runtime-after.prof to see memory consumers

This test should take memory samples within TestGazillion instead.

@IdoZilberberg IdoZilberberg added the flakiness Flakiness nature of the system or tests label Sep 25, 2019
@electricmonk electricmonk changed the title TestMemoryLeaks_DuringRuntime Memory leak tests are currently skipped Dec 1, 2019
@electricmonk electricmonk removed the flakiness Flakiness nature of the system or tests label Dec 1, 2019
@electricmonk
Copy link
Contributor

we need to decide if we want to fix these tests, or whether we're counting on Marvin to pinpoint any memory issue we might have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants