Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate ForeverHandle.MarkSupervised() #1458

Open
ronnno opened this issue Nov 13, 2019 · 1 comment
Open

deprecate ForeverHandle.MarkSupervised() #1458

ronnno opened this issue Nov 13, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@ronnno
Copy link
Contributor

ronnno commented Nov 13, 2019

This method became obsolete after recent changes to the supervision mechanism.

We use it outside of govnr only in one case where we want to bypass the supervision mechanism. near it, this comment appears: //TODO use real supervision?

In this case, we should either conform to the supervision semantics or stop using govnr altogether, or otherwise replace this method with a clearer ForeverNoShutdownSupervision() (which will not return a ForeverHandler but only a channel which is closed upon termination instead), or rename this workaround method so it's clear that it does the opposite of what it current name suggests: either MarkUnsupervised() to RunForeverWithoutSupervision()

Once the method is deprecated it should be marked as in internal function to govnr and not exposed to consuming modules

@ronnno ronnno added the good first issue Good for newcomers label Nov 13, 2019
@electricmonk
Copy link
Contributor

I'd like to wait with any further changes to govnr until we decide what we want to do with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants