Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run tests locally #612

Closed
mattgodbolt opened this issue Jul 15, 2023 · 11 comments
Closed

Unable to run tests locally #612

mattgodbolt opened this issue Jul 15, 2023 · 11 comments
Labels
bug Something isn't working stale No activity

Comments

@mattgodbolt
Copy link

mattgodbolt commented Jul 15, 2023

Long time user and now trying to fork and fix some things myself.

However, cloning, then npm install then npm run test fails during the grunt task sass:build with:

Fatal error: Error: $color1: var(--bs-border-color) is not a color.

-- Can anyone help me understand what I'm doing wrong? I tried applying some of the sass-fixing PRs but no luck.

@mattgodbolt mattgodbolt added the bug Something isn't working label Jul 15, 2023
@mattgodbolt mattgodbolt changed the title Unable to rnu tests locally Unable to run tests locally Jul 15, 2023
@mattgodbolt
Copy link
Author

Hackily commenting out the bootstrap5 support (which my project doesn't need) and ...

> [email protected] test
> karma start

15 07 2023 13:23:08.529:ERROR [plugin]: Cannot find plugin "/home/matthew/dev/tom-select/node_modules/karma-accessibility-checker".
  Did you forget to install it?
  npm install /home/matthew/dev/tom-select/node_modules/karma-accessibility-checker --save-dev
15 07 2023 13:23:08.856:ERROR [karma-server]: Server start failed on port 9876: Error: No provider for "framework:aChecker"! (Resolving: framework:aChecker)
15 07 2023 13:23:08.858:ERROR [reporter]: Can not load reporter "aChecker", it is not registered!
  Perhaps you are missing some plugin?

I am clearly missing something :)
I'm doing an npm install and then npm run test

@craigh
Copy link

craigh commented Jul 20, 2023

I see the same errors. disabling BS5 support is not an option for me :(

@craigh
Copy link

craigh commented Jul 20, 2023

@mattgodbolt we are trying to make a workable fork also. We fixed some of the issues with the color thing you mentioned here but still have the karma test errors.

@mattgodbolt
Copy link
Author

Thanks @craigh . BS5 is required for me too, I was just trying to work out what options I had.

@craigh
Copy link

craigh commented Jul 24, 2023

@mattgodbolt give https://www.npmjs.com/package/@remotedevforce/tom-select a try. I haven't tested it yet, but I think it is ready.

@mattgodbolt
Copy link
Author

Thanks! Will do!

@craigh
Copy link

craigh commented Jul 25, 2023

@mattgodbolt I tested this today and had to make some changes. I released v2.2.5 at https://www.npmjs.com/package/@remotedevforce/tom-select and it works with Bootstrap 5.3! You can see the repo here: https://github.com/RemoteDevForce/tom-select where I have merged #534 and #601. These solve the issues I was concerned about.

@mattgodbolt
Copy link
Author

I'm a bit of a noob when it comes to replacing an existing package with a forked version: I npm r'd tom-select and then npm'd yours ... is there a way to use yours in place of tom-=select or do I need to go through my whole program and update all the tom-select requires and whatnot with @remotedevforce/tom-select or similar? (I'll do that...but just in case I'm being silly...)

@mattgodbolt
Copy link
Author

Well...with that change I was able to load up but I get a new and exciting set of type errors as per #518. Some heinous casting might get it working, but this is sadly another reason why a good answer for the future of this would be nice (maybe moving to your fork and trying to fix these things?) Thank you for the work so far!

@craigh
Copy link

craigh commented Jul 26, 2023

@mattgodbolt I'm a total newb with all this. Looks like you got a good start in your PR so you have the idea. I've not tried to build any typescript, so I've not dealt with that issue. We have a TS dev in our repo, so let's move further discussion to my repo discussions or issues instead of further polluting this.

Copy link

This issue has not been active in 120 days and has been marked "stale". Remove stale label or comment or this will be closed in 15 days

@github-actions github-actions bot added the stale No activity label Nov 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale No activity
Projects
None yet
Development

No branches or pull requests

2 participants