-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to run tests locally #612
Comments
Hackily commenting out the bootstrap5 support (which my project doesn't need) and ...
I am clearly missing something :) |
I see the same errors. disabling BS5 support is not an option for me :( |
@mattgodbolt we are trying to make a workable fork also. We fixed some of the issues with the color thing you mentioned here but still have the karma test errors. |
Thanks @craigh . BS5 is required for me too, I was just trying to work out what options I had. |
@mattgodbolt give https://www.npmjs.com/package/@remotedevforce/tom-select a try. I haven't tested it yet, but I think it is ready. |
Thanks! Will do! |
@mattgodbolt I tested this today and had to make some changes. I released v2.2.5 at https://www.npmjs.com/package/@remotedevforce/tom-select and it works with Bootstrap 5.3! You can see the repo here: https://github.com/RemoteDevForce/tom-select where I have merged #534 and #601. These solve the issues I was concerned about. |
I'm a bit of a noob when it comes to replacing an existing package with a forked version: I |
Well...with that change I was able to load up but I get a new and exciting set of type errors as per #518. Some heinous casting might get it working, but this is sadly another reason why a good answer for the future of this would be nice (maybe moving to your fork and trying to fix these things?) Thank you for the work so far! |
@mattgodbolt I'm a total newb with all this. Looks like you got a good start in your PR so you have the idea. I've not tried to build any typescript, so I've not dealt with that issue. We have a TS dev in our repo, so let's move further discussion to my repo discussions or issues instead of further polluting this. |
This issue has not been active in 120 days and has been marked "stale". Remove stale label or comment or this will be closed in 15 days |
Long time user and now trying to fork and fix some things myself.
However, cloning, then
npm install
thennpm run test
fails during the grunt tasksass:build
with:-- Can anyone help me understand what I'm doing wrong? I tried applying some of the sass-fixing PRs but no luck.
The text was updated successfully, but these errors were encountered: