Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-progress should suppress benchmark-target's logs #288

Open
MahdiBM opened this issue Oct 8, 2024 · 3 comments
Open

--no-progress should suppress benchmark-target's logs #288

MahdiBM opened this issue Oct 8, 2024 · 3 comments

Comments

@MahdiBM
Copy link
Contributor

MahdiBM commented Oct 8, 2024

--no-progress should suppress benchmark-target's logs.
e.g. I see Vapor logs when I run the benchmarks + the comparison in one go, with benchmark thresholds check.

@MahdiBM
Copy link
Contributor Author

MahdiBM commented Oct 8, 2024

I think optimally there would be an option to somehow keep the logs for debugging?
Like save the logs somewhere?
So --no-progress does suppress the logs, but another flag direct the runner to save the logs to a file.
Something like that ... because the logs might still be needed for debugging.

@hassila
Copy link
Contributor

hassila commented Feb 11, 2025

Not sure how I can suppress logs for arbitrary frameworks?

@MahdiBM
Copy link
Contributor Author

MahdiBM commented Feb 11, 2025

I think what I meant by this is that the benchmarking package should simply just suppress all stdout logs of the target when it's running the benchmarks. So if a benchmarks has a bunch of debugging prints or other logs, optimally none of them would show up.
Is that hard to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants