Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ParameterReq with a populated requests field but an empty param and value field #20

Open
notthetup opened this issue Jul 7, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@notthetup
Copy link
Collaborator

fjage defines that a ParameterReq should always have the param field set, and only use the requests field for the 2nd parameter onwards. However, the Fjage.java implementation does support a ParameterReq with all the parameters set in the requests field and an empty param field.

We should update Fjage.jl to follow Fjage.java implementation and accept such messages as well.

For example..

The correct way..

1657162337106|FINE|org.arl.fjage.remote.ConnectionHandler@115:run|tcp:///10.30.0.229:1100//10.30.0.248.59508 <<< {"id":"49916647-d700-49b1-9c5e-e46d2eed19eb","action":"send","message":{"clazz":"org.arl.fjage.param.ParameterReq","data":{"index":-1,"requests":null,"param":"pbscnt","value":1,"msgID":"49916647-d700-49b1-9c5e-e46d2eed19eb","perf":"REQUEST","recipient":"bb","sender":"unetsh#-ly2bin","inReplyTo":null,"sentAt":1657162337054}},"relay":true}

vs the incorrect way (which I propose should be supported)

1657161986677|FINE|org.arl.fjage.remote.ConnectionHandler@100:run|tcp:///10.30.0.229:1100//10.30.0.248.59346 <<< {"action": "send", "relay": true, "message": { "clazz": "org.arl.fjage.param.ParameterReq", "data": {"msgID":"3e0a4748-bfd7-4f95-b3bd-04112524707a","perf":"REQUEST","recipient":"bb","sender":"PythonGW-422a2914-cd67-4b66-a045-b47c03d67716","inReplyTo":null,"index":-1,"requests":[{"param":"pbscnt","value":1}]} }}

@mchitre mchitre self-assigned this Jul 7, 2022
@mchitre mchitre added the enhancement New feature or request label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants