Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A road section disappears on lower zooms #10107

Open
pastk opened this issue Jan 21, 2025 · 1 comment
Open

A road section disappears on lower zooms #10107

pastk opened this issue Jan 21, 2025 · 1 comment
Labels
Bug Something isn't working Drape Drape OpenGL, Vulkan and Metal graphics rendering engine

Comments

@pastk
Copy link
Member

pastk commented Jan 21, 2025

https://www.openstreetmap.org/way/172544089#map=15/48.10010/37.94158
Its highway=secondary so should be visible from z10-.

But the section disappears on z12 and earlier (Android device):
Image

What's weird in that on the linux desktop its rendered on z12, but is absent on z10-11 still (the maps are the same of course)
Image

So it could be a bug of the lines simplification algo in the generator (produces an invalid result) or a rendering bug in the drape engine.

@vng FYI

@pastk pastk added Bug Something isn't working Drape Drape OpenGL, Vulkan and Metal graphics rendering engine Generator Related to generator tool. labels Jan 21, 2025
@pastk
Copy link
Member Author

pastk commented Jan 21, 2025

Looks like a bug of the extra run-time simplification (ref ApplyLineFeatureGeometry::operator()).

The way is almost circular (the start and the end are very close to each other). So at some point the algo decides to make a short-cut between them and skip all other points of the spline :)

The affected zoom level is different for various devices because they have different dpi, which affects the simplification thresholds.

IMO this run-time simplification is redundant and should be dropped.

@pastk pastk removed the Generator Related to generator tool. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Drape Drape OpenGL, Vulkan and Metal graphics rendering engine
Projects
None yet
Development

No branches or pull requests

1 participant