Chunk Render error after changing CauldronBehavior interface by mixin #1937

theAfish · 2021-12-26T04:33:01Z

theAfish
Dec 26, 2021

Hi, all

Recently I added a custom bucket in Minecraft 1.18.1. Then I tried to change the CauldronBehavior interface in order to add new interaction between the custom bucket and empty or water cauldron. The Mixin file is shown below:

@Mixin(CauldronBehavior.class)
public interface CauldronBehaviorMixin {

   @Final
   @Shadow
   Map<Item, CauldronBehavior> WATER_CAULDRON_BEHAVIOR = null;

   @Final
   @Shadow
   Map<Item, CauldronBehavior> EMPTY_CAULDRON_BEHAVIOR = null;

   @Final
   @Shadow
   CauldronBehavior FILL_WITH_WATER = null;

   @Inject(method = "registerBehavior()V", at = @At("HEAD"))
   private static void addBehavior(CallbackInfo ci){
       WATER_CAULDRON_BEHAVIOR.put(ItemInit.WOODEN_BUCKET, (state, world, pos, player, hand, stack) -> {
           return emptyCauldron(state, world, pos, player, hand, stack, new ItemStack(ItemInit.WATER_WOODEN_BUCKET), (statex) -> {
               return (Integer)statex.get(LeveledCauldronBlock.LEVEL) == 3;
           }, SoundEvents.ITEM_BUCKET_FILL);
       });
       EMPTY_CAULDRON_BEHAVIOR.put(ItemInit.WATER_WOODEN_BUCKET, FILL_WITH_WATER);
   }


   @Shadow
   static ActionResult emptyCauldron(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand hand, ItemStack stack, ItemStack output, Predicate<BlockState> predicate, SoundEvent soundEvent) {
       return null;
   }
}

It works well after modification. However, there is something wrong. After the modification, the chunks containing blocks in my mod cannot be loaded correctly, and almost all items in my mod's itemGroup disappear (Seems like something is wrong with the item register). Like this:

With error showed:

[11:28:27] [Render thread/FATAL] (Minecraft) Error executing task on Client
 java.lang.IllegalArgumentException: No value with id -1
	at net.minecraft.util.collection.IndexedIterable.getOrThrow(IndexedIterable.java:19) ~[[email protected]:?]
	at net.minecraft.world.chunk.ArrayPalette.readPacket(ArrayPalette.java:82) ~[[email protected]:?]
	at net.minecraft.world.chunk.PalettedContainer.readPacket(PalettedContainer.java:163) ~[[email protected]:?]
	at net.minecraft.world.chunk.ChunkSection.fromPacket(ChunkSection.java:157) ~[[email protected]:?]
	at net.minecraft.world.chunk.WorldChunk.loadFromPacket(WorldChunk.java:445) ~[[email protected]:?]
	at net.minecraft.client.world.ClientChunkManager.loadChunkFromPacket(ClientChunkManager.java:101) ~[[email protected]:?]
	at net.minecraft.client.network.ClientPlayNetworkHandler.loadChunk(ClientPlayNetworkHandler.java:665) ~[[email protected]:?]
	at net.minecraft.client.network.ClientPlayNetworkHandler.onChunkData(ClientPlayNetworkHandler.java:660) ~[[email protected]:?]
	at net.minecraft.network.packet.s2c.play.ChunkDataS2CPacket.apply(ChunkDataS2CPacket.java:45) ~[[email protected]:?]
	at net.minecraft.network.packet.s2c.play.ChunkDataS2CPacket.apply(ChunkDataS2CPacket.java:12) ~[[email protected]:?]
	at net.minecraft.network.NetworkThreadUtils.method_11072(NetworkThreadUtils.java:21) ~[[email protected]:?]
	at net.minecraft.util.thread.ThreadExecutor.executeTask(ThreadExecutor.java:151) [[email protected]:?]
	at net.minecraft.util.thread.ReentrantThreadExecutor.executeTask(ReentrantThreadExecutor.java:23) [[email protected]:?]
	at net.minecraft.util.thread.ThreadExecutor.runTask(ThreadExecutor.java:125) [[email protected]:?]
	at net.minecraft.util.thread.ThreadExecutor.runTasks(ThreadExecutor.java:110) [[email protected]:?]
	at net.minecraft.client.MinecraftClient.render(MinecraftClient.java:1080) [[email protected]:?]
	at net.minecraft.client.MinecraftClient.run(MinecraftClient.java:733) [[email protected]:?]
	at net.minecraft.client.main.Main.main(Main.java:238) [[email protected]:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:602) [fabric-loader-0.12.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) [fabric-loader-0.12.11.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.12.11.jar:?]
	at net.fabricmc.devlaunchinjector.Main.main(Main.java:86) [dev-launch-injector-0.2.1+build.8.jar:?]

Does anyone know what's happening? Is the formatting of the mixin incorrect?

Answered by warjort

Dec 26, 2021

So can I just change the public method in that interface without mixin? Or if there is any method to let mixin invoked after the initialize of ItemInit, this problem would be handled?

You can just modify the maps in your mod initialiser.
The maps are public static so you can call their methods directly.

Something like (untested code):

   // Method inside your mod initialiser class (should be invoked after your bucket is initialised)
   public static void initialiseCauldron(){
       // Use static references to the CauldronBehavior.maps
       CauldronBehavior.WATER_CAULDRON_BEHAVIOR.put(ItemInit.WOODEN_BUCKET, (state, world, pos, player, hand, stack) -> {
           return CauldronBehav…

View full answer

warjort · 2021-12-26T11:15:56Z

warjort
Dec 26, 2021
Collaborator

 java.lang.IllegalArgumentException: No value with id -1
	at net.minecraft.util.collection.IndexedIterable.getOrThrow(IndexedIterable.java:19) ~[[email protected]:?]
	at net.minecraft.world.chunk.ArrayPalette.readPacket(ArrayPalette.java:82) ~[[email protected]:?]
	at net.minecraft.world.chunk.PalettedContainer.readPacket(PalettedContainer.java:163) ~[[email protected]:?]
	at net.minecraft.world.chunk.ChunkSection.fromPacket(ChunkSection.java:157) ~[[email protected]:?]
	at net.minecraft.world.chunk.WorldChunk.loadFromPacket(WorldChunk.java:445) ~[[email protected]:?]
	at net.minecraft.client.world.ClientChunkManager.loadChunkFromPacket(ClientChunkManager.java:101) ~[[email protected]:?]

The palette in the chunk manager is responsible for finding the block states on the client.
The error says it can't find the corresponding block state when the data arrives on the client.
i.e. something was not registered properly or it just isn't a valid state.

However, there is something wrong. After the modification, the chunks containing blocks in my mod cannot be loaded correctly, and almost all items in my mod's itemGroup disappear (Seems like something is wrong with the item register).

So is that palette error caused by your block(s) or the changed cauldron state?

Sounds like your Cauldron mixin is causing a problem earlier than the error you show?
If you can't see anything obvious in the log, I would start by adding some log statements to assert that things are being done properly.
e.g. that your block/items are getting registered and that your cauldron registration mixin does it stuff without an error, etc.
If that is all correct, I would add some logging to see what block state your mixin puts the cauldron in and check it is a valid state

0 replies

warjort · 2021-12-26T11:34:07Z

warjort
Dec 26, 2021
Collaborator

By the way, I am wondering why you need the mixin?

The CauldronBehaviour is an interface. Those maps you are modifying are public static fields.
You can modify them in your mod intitialiser.

0 replies

warjort · 2021-12-26T11:45:23Z

warjort
Dec 26, 2021
Collaborator

By the way, I am wondering why you need the mixin?

In fact, that might be your problem?
The method you mixin is being invoked during the minecraft Bootstrap() which will trigger your ItemInit class static initialiser before the main minecraft data like the registries have been fully initialised.
Depending upon what your ItemInit does you could be trying to use data that isn't yet in a valid state (or causing something else to do so).

1 reply

theAfish Dec 26, 2021
Author

Oh, this sounds very reasonable! Because this mixin calls the WOODEN_BUCKET inside the ItemInit class.

Thank you for your reply :)

Actually, I am new to java and newer to mixin. So my logic may not be as clear as that of a professional programmer. Here are my original thoughts:

I want my wooden bucket to interact with the vanilla cauldron. So there are two ways I could think out:

Write a reasonable use() method of the wooden bucket to get the level and fluid inside the cauldron while right-clicking.
Adding new behaviors to the vanilla cauldron.

After reading through how vanilla Minecraft did to realize the interaction, I thought the second way is more "natural" to Minecraft. Then the easiest way I could think of is to use the mixin to add new behaviors to the CauldronBehavior interface. And that's why I used mixin.

So can I just change the public method in that interface without mixin? Or if there is any method to let mixin invoked after the initialize of ItemInit, this problem would be handled?

Thanks again!

warjort · 2021-12-26T12:53:29Z

warjort
Dec 26, 2021
Collaborator

So can I just change the public method in that interface without mixin? Or if there is any method to let mixin invoked after the initialize of ItemInit, this problem would be handled?

You can just modify the maps in your mod initialiser.
The maps are public static so you can call their methods directly.

Something like (untested code):

   // Method inside your mod initialiser class (should be invoked after your bucket is initialised)
   public static void initialiseCauldron(){
       // Use static references to the CauldronBehavior.maps
       CauldronBehavior.WATER_CAULDRON_BEHAVIOR.put(ItemInit.WOODEN_BUCKET, (state, world, pos, player, hand, stack) -> {
           return CauldronBehavior.emptyCauldron(state, world, pos, player, hand, stack, new ItemStack(ItemInit.WATER_WOODEN_BUCKET), (statex) -> {
               return (Integer)statex.get(LeveledCauldronBlock.LEVEL) == 3;
           }, SoundEvents.ITEM_BUCKET_FILL);
       });
       CauldronBehavior.EMPTY_CAULDRON_BEHAVIOR.put(ItemInit.WATER_WOODEN_BUCKET, FILL_WITH_WATER);
   }

2 replies

theAfish Dec 26, 2021
Author

It worked! Didn't think it would be so easy to fix. Thanks again for teaching me this kind of way to initialize methods!

kanpov Dec 27, 2021

\s initialize

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FabricMC

Chunk Render error after changing CauldronBehavior interface by mixin #1937

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 4 comments 3 replies

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

FabricMC

Chunk Render error after changing CauldronBehavior interface by mixin #1937

theAfish Dec 26, 2021

Replies: 4 comments · 3 replies

warjort Dec 26, 2021 Collaborator

warjort Dec 26, 2021 Collaborator

warjort Dec 26, 2021 Collaborator

theAfish Dec 26, 2021 Author

warjort Dec 26, 2021 Collaborator

theAfish Dec 26, 2021 Author

kanpov Dec 27, 2021

theAfish
Dec 26, 2021

Replies: 4 comments 3 replies

warjort
Dec 26, 2021
Collaborator

warjort
Dec 26, 2021
Collaborator

warjort
Dec 26, 2021
Collaborator

theAfish Dec 26, 2021
Author

warjort
Dec 26, 2021
Collaborator

theAfish Dec 26, 2021
Author