-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support opening the first HTTP reference in browser (#11) #15
feat: support opening the first HTTP reference in browser (#11) #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! It looks good to me overall. Just had one comment about refactoring.
Also, can you update README.md about this new key binding?
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
========================================
- Coverage 8.27% 8.14% -0.13%
========================================
Files 13 13
Lines 701 712 +11
========================================
Hits 58 58
- Misses 643 654 +11 ☔ View full report in Codecov by Sentry. |
- improve code simplicity - better error printing with eprintln Co-authored-by: Orhun Parmaksız <[email protected]>
I got your changes with fixings. |
We can continue with this PR. You can simply update the key bindings table to mention this new functionality and I think that will be enough. |
I couldn't see available key bindings table in README.md so I add a new table. #20 |
Oops, I thought I added it 😅 Thanks for the PR! |
Description of change
Users will now be able to open CVE reference URL's directly in their browsers via pressing
Space
(#11)Add new Pattern to handling the
Space
character. If user pressed theSpace
key on the details, look for all references starting with 'http' and open the first URL in the web browser if available.New Dependency
Add webbrowser dependency to open browser on cross platform. 1026380
How has this been tested?
🟢 Run all tests
Manual Test Cases
CVE has no references | (1/3)
CVE has reference without any http URL | (2/3)
CVE has reference with http URL | (3/3)
Known Linter Warnings
This is my first rust experience. Please feel free to tell me if you see anything wrong in this PR.