Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use unbounded channels in online audio processing #304

Closed
orottier opened this issue Jun 21, 2023 · 0 comments · Fixed by #308
Closed

Do not use unbounded channels in online audio processing #304

orottier opened this issue Jun 21, 2023 · 0 comments · Fixed by #308
Assignees

Comments

@orottier
Copy link
Owner

As mentioned in #297:

I also consider using unbounded channels for this purpose as inappropriate. For any for real world use case bounded channels are recommended. Moreover the receiver side of theses crossbeam channels cannot be used safely in a real-time context AFAIK.

The crossbeam channels seem to have serious unresolved issues: crossbeam-rs/crossbeam#821

The AudioContext (as opposed to the OfflineAudioContext) should only use bounded channels.
It is probably okay for the control thread to block on a full channel.
It is probably okay for the render thread to drop data when a channel is full (we use them for events and metrics).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant