Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite audio nodes to use proper message passing instead of atomics #315

Closed
4 of 5 tasks
orottier opened this issue Jul 11, 2023 · 2 comments
Closed
4 of 5 tasks

Rewrite audio nodes to use proper message passing instead of atomics #315

orottier opened this issue Jul 11, 2023 · 2 comments
Assignees
@b-ma

Comments

@orottier
Copy link
Owner

orottier commented Jul 11, 2023 •
edited
Loading

Continuation from the initial work of #311 , these nodes still need changes:

  • BiquadFilterNode
  • ConvolverNode
  • PannerNode
  • WaveShaperNode

For further consideration

  • also rewrite the ChannelConfig to use message passing
@orottier orottier mentioned this issue Jul 18, 2023
Merged
@b-ma b-ma mentioned this issue Jul 19, 2023
Merged
@b-ma
Copy link
Collaborator

b-ma commented Jul 19, 2023

Actually about #329, I think I will just remove the new LoopControl struct as there is finally no Arc, anything on your sides against that?

@orottier
Copy link
Owner Author

Fixed with #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-ma b-ma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@b-ma @orottier