Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI status is still slightly inconsistent #13

Open
ochosi opened this issue Dec 21, 2023 · 0 comments
Open

CI status is still slightly inconsistent #13

ochosi opened this issue Dec 21, 2023 · 0 comments

Comments

@ochosi
Copy link
Collaborator

ochosi commented Dec 21, 2023

There is still a corner case I'm unsure how to handle. When a PR has checks defined, but they haven't been triggered (I presume that external contributors don't have the permissions in this case?), the API returns total_count = 0.
So while the correct state would be pending, we cannot know if there are maybe no GitHub checks defined or if they haven't been triggered.
Here's a PR that I ran into with this problem: osbuild/cloud-image-val#283
It's currently part of the queue, even though CI hasn't run.

Also see https://github.com/ochosi/pr-review-queue/pull/9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant