Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid OtherPackagesLoadedInAdvance #1155

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

fingolfin
Copy link
Member

Recent GAP versions include _StripEscapeSequences, use that instead of
StripEscapeSequences from GAPDoc

Recent GAP versions include _StripEscapeSequences, use that instead of
StripEscapeSequences from GAPDoc
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (50aca12) to head (becd0fc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/JuliaInterface/gap/utils.gi 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   74.52%   74.51%   -0.01%     
==========================================
  Files          55       55              
  Lines        4714     4713       -1     
==========================================
- Hits         3513     3512       -1     
  Misses       1201     1201              
Files with missing lines Coverage Δ
pkg/JuliaInterface/PackageInfo.g 90.26% <ø> (-0.09%) ⬇️
pkg/JuliaInterface/gap/utils.gi 24.61% <0.00%> (ø)

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.
(When we removed the OtherPackagesLoadedInAdvance from GAP, we had just checked that this removal does not affect packages that are distributed with GAP, and JuliaInterface is not a distributed package.)

@fingolfin fingolfin enabled auto-merge (squash) February 10, 2025 14:27
@fingolfin fingolfin merged commit 17b5967 into master Feb 10, 2025
170 checks passed
@fingolfin fingolfin deleted the mh/OtherPackagesLoadedInAdvance branch February 10, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants