Added function to compute defining ideal of flag variety

[danteluber]

This function computes the defining ideal of the flag variety $Fl(w,n)$, where $w = (d_1,...d_k)$, $d_j\leq n-1$, denotes the rank, and $n$ is the dimension of the ambient vector space.

[lgoettgens]

I think it would make sense to accept the field as an argument instead of always taking QQ.

[fingolfin]

Some general Julia hints

[lgoettgens]

Please don't re-format the whole file as that may lead to many conflicts with other pull requests. (and it makes it way harder to find the "real" changes)

[lkastner]

(and it makes it way harder to find the "real" changes)

You can actually hide whitespace changes in the Files changed view, the option is in the drop down menu with the settings wheel. Similarly git blame has a flag

    -w                    ignore whitespace differences

It is really quite annoying that we want devs to format their code properly, but refuse to format our code and thereby blocking them from using tools like JuliaFormatter that would make this easy. At the same time we block ourselves from having this tested automatically.

[lgoettgens]

It is really quite annoying that we want devs to format their code properly, but refuse to format our code and thereby blocking them from using tools like JuliaFormatter that would make this easy. At the same time we block ourselves from having this tested automatically.

I totally agree with you. But I think it should be managed by a central instance and applied at a defined time so that everyone with open changes can prepare for that.
Once we have formatted files, keeping the formatting is way easier than the current state of things.

[lgoettgens]

thanks for the formatting. some more comments for consistency with other parts of oscar

[lgoettgens]

@danteluber Could you click on the "Resolve conversation" button of everything you already took care of? This makes it a bit easier for everyone to follow what's going on in this thread.

[Sequenzer]

I have nothing to complain about, except that we might want to change this function so that it computes the minimal set of generators.