-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Modules over PBWAlgRing and PBWAlgQuo #3900
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,61 @@ | |||
@testset "modules over PBWAlgQuo" begin | |||
#Free Module tests | |||
E,x = exterior_algebra(QQ, 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is part of experimental and should thus not be used in the tests for src/
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Though maybe we need to look into promoting exterior_algebra one of these days?
In any case, note that this PR is still a very early draft, I mainly asked @Lax202 to open it so we can better see what she's doing and what the state is, and then discuss it. The code still needs to be consolidated into a new source file, and that may very well ultimately end up in the experimental
tree. We'll see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime this was merged as part of PR #3988 which copied the tests from here. If we still don't want the exterior_algebra
call here, then someone else should remove it from there.
This needs a decision how to proceed regarding the orderings. Perhaps @wdecker will be in this week, so we can have a chat about it? Or Zoom/Phone/whatever? |
@fingolfin Zooom, gathertown is o.k. when? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some rather technical (not mathematics-related) comments
This is a draft pull request for the work to extend FreeMod, SubModuleofFreeModule, SubquoModule to PBWAlgRing and PBWAlgQuo. The aim is to extend the Groaner machinery as well.