Database on Enriques surfaces and docu #4560
Conversation
simonbrandhorst
commented
Feb 7, 2025
•
simonbrandhorst
commented
- database of Enriques surfaces and docu
|
Could you please rebase this onto the latest master branch? Currently, github shows #4540 as part of the changes, which makes it incredibly difficult to see the "real changes". |
|
|
||
| The group ``\mathrm{Aut}(Y)`` is a dihedral group of order ``8`` and its image ``\mathrm{Aut}^*(Y)`` in ``O(S_Y)`` is a group of order ``4``. It is this group we compute. | ||
| ```jldoctest EnriquesAut | ||
| julia> SY, SX, L26, w, u = load("data/TauTaubarGenericEnriquesSurfaces/TauTaubarGenericEnriquesSurfaceNo172.mrdi"); |
There was a problem hiding this comment.
If the surfaces are numbered then it probably makes sense to implement a load_enriques_surface function and then users can just pass an int as oppose to trying to find the path similar to the johnson_solid function or similar to the code Oscar/src/AlgebraicGeometry/Surfaces/SurfacesP4.jl .
Then adding a test in the data section to make sure we are still able to load the files when there is an upgrade is also import.
There was a problem hiding this comment.
Thanks for the suggestion. Done.
There was a problem hiding this comment.
The test is part of a doctest.
There was a problem hiding this comment.
Or should I add a test in the data section anyways?
There was a problem hiding this comment.
If the data between files has exactly the same types then this should be fine.
Otherwise it would good to make sure that we test all files with different type structure.
There was a problem hiding this comment.
All exactly the same types.
There was a problem hiding this comment.
Great, then I think the doc test is sufficient
simonbrandhorst
force-pushed
the
sb/enriques_wip
branch
from
76e3e45 to
75c6bdd
Compare
Co-authored-by: Lars Göttgens <[email protected]>
…to sb/enriques_wip
|
Should be good to go for my part. |
