Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 links go to a blank page #30

Open
dwsilk opened this issue Jun 28, 2019 · 1 comment
Open

404 links go to a blank page #30

dwsilk opened this issue Jun 28, 2019 · 1 comment

Comments

@dwsilk
Copy link

dwsilk commented Jun 28, 2019

e.g. https://2019.foss4g-oceania.org/brokenlink/

Might be nice to add a little message and redirect back to home.

@alpha-beta-soup
Copy link
Collaborator

alpha-beta-soup commented Jul 2, 2019

I had a go at implementing this, and the work is in a branch: https://github.com/foss4g-oceania/hoverboard/tree/404 (Direct link to diff.)

I got as far as reaching a 404.html document if navigated directly to it. However, still the same behaviour otherwise. I'm not familiar with Firebase hosting beyond this project so I'm not really sure what else to try. Perhaps there's something to tweak in the console?

Docs are here: https://firebase.google.com/docs/hosting/full-config#404

There's nothing in upstream Hoverboard fork about a 404 page that I can see, just a few opaque issues; but it might be worth raising a new issue there to at least ask how. It would be better to rebase our fork first.

The existing config, if I'm interpreting it correctly, should already redirect back to index.html (albeit silently). That it doesn't, AFAICT, is a bug. The client doesn't actually seem to get either a 4XX or 3XX response at any point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants