Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest file configured with minimum required settings #5

Merged
merged 1 commit into from
May 26, 2023

Conversation

mbildstein
Copy link
Collaborator

Manifest file configured

  • Manifest file configured with minimum required settings for chrome extension.
  • Several entries required placeholders, which will need to be updated later: icons, authors, devtools_page

Gitignore files consolidated

  • gitignore files from /npm-package and /chrome-extension consolidated into single gitignore file in root directory to avoid conflicts

Copy link
Contributor

@li-lucia li-lucia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wnguye03 wnguye03 self-requested a review May 26, 2023 23:38
Copy link
Contributor

@wnguye03 wnguye03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manifest looks great to me!

@wnguye03 wnguye03 merged commit 40ec6ad into dev May 26, 2023
@YouruiR YouruiR linked an issue Jun 1, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome extension manifest needs replacements for placeholders
3 participants