Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign highway shield based on ref value #142

Closed
Mashin6 opened this issue Feb 5, 2022 · 4 comments · Fixed by #376
Closed

Assign highway shield based on ref value #142

Mashin6 opened this issue Feb 5, 2022 · 4 comments · Fixed by #376
Labels
internationalization mapping Changes needed to OpenStreetMap shields

Comments

@Mashin6
Copy link
Contributor

Mashin6 commented Feb 5, 2022

In some communities they have chosen to group all their roads under a single network value with an assumption that certain letter codes in ref would be sufficient to split them apart. An option would be to define shield graphics not only by an exact match of network, but also by an additional regex match in ref values.
This will have to be carefully crafted around ref preprocessing #141 in case it will be implemented.

Countries that are affected:
Hungary #69
Portugal
Bulgaria
North Macedonia

@1ec5
Copy link
Member

1ec5 commented Feb 5, 2022

In some communities they have chosen to group all their roads under a single network value with an assumption that certain letter codes in ref would be sufficient to split them apart.

As I understand it, the main reason for migrating to route relations with distinct networks was to keep data consumers from having to sniff out alphabetic codes the way they had been with refs on ways. It would be helpful to know the reasoning behind replicating the same unstructured format on relation refs. Maybe these communities could be convinced to make their route relation tagging more structured.

@1ec5 1ec5 added mapping Changes needed to OpenStreetMap internationalization labels Feb 5, 2022
@Mashin6
Copy link
Contributor Author

Mashin6 commented Feb 6, 2022

With Hungarian community that didn't work out.

There is also an option of not doing anything about it. It's all just a suggestion.

@claysmalley
Copy link
Member

claysmalley commented Jun 9, 2022

#355 #376 adds support for this, though regex matching is not implemented, so each ref=* with a special-case shield needs to be defined individually.

@ZeLonewolf
Copy link
Member

ZeLonewolf commented Jun 9, 2022

My impression is that the countries listed have grouped together multiple de facto highway networks under a common network value, and that this is properly solved with a tagging solution rather than a rendering one. Thus, I agree with closing this issue upon merge of #355 #376, as the ask here "assign highway shield based on ref value" will be resolved. I don't think we should make special code for the case of insufficiently structured network tagging schemes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internationalization mapping Changes needed to OpenStreetMap shields
Projects
Development

Successfully merging a pull request may close this issue.

5 participants