Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Cloud sync doesn't restore tracks, favorites correctly #4252

Open
4 tasks done
vshcherb opened this issue Dec 29, 2024 · 9 comments · Fixed by #4289, #4294, #4295 or #4299 · May be fixed by #4306
Open
4 tasks done

iOS Cloud sync doesn't restore tracks, favorites correctly #4252

vshcherb opened this issue Dec 29, 2024 · 9 comments · Fixed by #4289, #4294, #4295 or #4299 · May be fixed by #4306
Assignees
Milestone

Comments

@vshcherb
Copy link
Member

vshcherb commented Dec 29, 2024

Crash

  • xcode://organizer/crashes/downloadPoint?adamId=934850257&platformId=iOS&installPlatformId=iOS&analyticsPointId=CNJVGDZSBDKbwZ6fJiy6sJ&bundleId=net.osmand.maps

  • Progress bar is broken. After downloading 1000 files it shows 1% syncing

After sync

  • After restoring tracks favorites from cloud all changes appear in Local tab

Screenshot
  • Last modified sorting in My Places doesn't work correctly. Looks like client time is not set on iOS after restoring from Cloud
@vshcherb vshcherb added this to the 4.9-iOS milestone Dec 29, 2024
@vshcherb vshcherb added the ! label Dec 29, 2024
@vshcherb vshcherb self-assigned this Dec 30, 2024
@vshcherb
Copy link
Member Author

Crash realted to missing .json.info files for profiles - should be ignored

profile_profile_bicycle.json  no file present profile_profile_bicycle.json.info 

@vshcherb vshcherb removed their assignment Dec 30, 2024
@vshcherb vshcherb removed the ! label Dec 30, 2024
@vshcherb vshcherb changed the title iOS Crash OsmAnd Cloud sync iOS Cloud sync doesn't restore tracks, favorites correctly Jan 2, 2025
@vshcherb vshcherb added the ! label Jan 2, 2025
@vshcherb vshcherb modified the milestones: 4.9-iOS, 5.0-iOS Jan 2, 2025
@vshcherb
Copy link
Member Author

vshcherb commented Jan 2, 2025

#4262

@Skalii Skalii linked a pull request Jan 9, 2025 that will close this issue
@Skalii
Copy link
Collaborator

Skalii commented Jan 9, 2025

  • Quick actions remain in Cloud tab after syncing

@vshcherb vshcherb modified the milestones: 5.0-iOS, 4.9-iOS Jan 14, 2025
@Skalii Skalii linked a pull request Jan 14, 2025 that will close this issue
@vshcherb
Copy link
Member Author

vshcherb commented Jan 14, 2025

Critical

  • A&S could not be downloaded
  • Cyrillic name files don't download correctly and constatly visible in Local

UI

  • Progress bar doesn't work 0%
  • Progress bar is not consistent - 2phases - gpx.info load and then gpx itself
  • Keep cell visible once item is downloaded (do not make blank & remove)
  • Broken cell rows in Local (Screenshot)
  • While downloading itesm from Cloud, scroll down / up and observe status of the cell is lost (incorrect)

Can't download from cloud

  • For testing: Quick actions - constantly in Cloud - broken Android upload ?
  • Search history - always in Local as deleted
  • Markers history - always in Local as deleted

Keep changing

This was linked to pull requests Jan 14, 2025
@vshcherb vshcherb self-assigned this Jan 15, 2025
@Skalii Skalii linked a pull request Jan 15, 2025 that will close this issue
@vshcherb vshcherb assigned tigrim and unassigned vshcherb and Skalii Jan 16, 2025
@Skalii Skalii linked a pull request Jan 16, 2025 that will close this issue
@Zirochkabila
Copy link
Collaborator

Zirochkabila commented Jan 20, 2025

Testing 1

4.9.4.4946

  1. After clicking on “Sync all”, the OsmAnd freezes (synchronization occurs in the background because after restarting, the number of changes in the cloud is reduced to 113 from 682) and crashes

Sync all 20 01 25 12 53.zip


  1. It is not possible to download all the data from the cloud, even after re-downloading, 51 files remain, which cannot be downloaded either individually or all together
51 Screenshot 2023-01-31 at 11 19 41

  1. While downloading items from Cloud, scroll down / up and observe status of the cell is lost (incorrect)
Cell is lost
Screen.Recording.2025-01-20.at.13.12.32.mov

@vshcherb vshcherb reopened this Jan 20, 2025
@vshcherb
Copy link
Member Author

vshcherb commented Jan 20, 2025

  • Progress goes > 100% in
- (void)onImportProgressUpdate:(NSInteger)value uploadedKb:(NSInteger)uploadedKb
{
    _importProgress = uploadedKb;
    float progress = (float) self.getGeneralProgress / _maxProgress;
    progress = progress > 1 ? 1 : progress;
    [NSNotificationCenter.defaultCenter postNotificationName:kBackupProgressUpdateNotification object:nil userInfo:@{@"progress": @(progress)}];
}
  • @tigrim Cell is not updated if it was not visible before download. Reproduce: start downloading, wait 80-90%, scroll down, all cells are higlighted as not downloaded by the logs they are already downloaded
  • Freezing error in the end (? related to not download item)
  • It is not possible to download all the data from the cloud, even after re-downloading, 51 files remain, which cannot be downloaded either individually or all together (account provided by @Zirochkabila )
  • After download fresh account Favorites, Profiles and Rendering styles displayed as outgoing changes - probably related to the freeze in the end which is related to the error of processing GPX (which couldn't be parsed)

@DmitrySvetlichny
Copy link
Contributor

Point "It is not possible to download all the data from the cloud, even after re-downloading, 51 files remain, which cannot be downloaded either individually or all together": When downloading the problematic file (specified in the issue) -
generateItemsJson error: filePath:/Users/dmitrysvetlichny/Library/Developer/CoreSimulator/Devices/07B6D26A-DEEB-4202-AE4B-80512C2D8AF4/data/Containers/Data/Application/F9892937-A201-4D26-9F2C-FEF9126940CB/tmp/backupTmp/GPX/import/04_HugBrid.gpx.info

<title>404 Not Found</title>

404 Not Found


nginx/1.18.0 (Ubuntu)

The file is missing from the server.

@nnngrach
Copy link
Contributor

nnngrach commented Feb 3, 2025

Not reproduced already. Moved task to test.

After download fresh account Favorites, Profiles and Rendering styles displayed as outgoing changes - probably related to the freeze in the end which is related to the error of processing GPX (which couldn't be parsed)

@Zirochkabila
Copy link
Collaborator

Testing 2

4.9.5.4962

Only the 4th point remains to be corrected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment