AO3-6911: prefer double quotes, add i18n support

otwcode · Feb 21, 2025 · 165261d · 165261d
1 parent c420089
commit 165261d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -28,7 +28,7 @@ def raise_not_found
   rescue_from Rack::Timeout::RequestTimeoutException, with: :raise_timeout
 
   def raise_timeout
-    redirect_to '/timeout'
+    redirect_to "/timeout"
   end
 
   helper :all # include all helpers, all the time

diff --git a/app/views/errors/timeout.html.erb b/app/views/errors/timeout.html.erb
@@ -1,2 +1,3 @@
-<h3 class="heading">The page was responding too slowly. Please try again after a few minutes.</h3>
-<p>If you still get this error after a few tries, you can  <%= link_to ts('contact Support'), new_feedback_report_path %>. In the form, please include a link to the page you're trying to reach and what action you are taking.</p>
+<h2 class="heading"><%= t("errors.timeout.title") %></h2>
+<h3 class="heading"><%= t("errors.timeout.subtitle") %></h3>
+<p><%= t("errors.timeout.html", contact_support_link: link_to(ts("contact Support"), new_feedback_report_path)) %></p>
diff --git a/config/locales/views/en.yml b/config/locales/views/en.yml
@@ -611,6 +611,11 @@ en:
         restricted_html: A translation of [Restricted Work] by %{creator_link}
         revealed_html: A translation of %{work_link} by %{creator_link}
         unrevealed: A translation of a work in an unrevealed collection
+  errors:
+    timeout:
+      title: Timeout
+      subtitle: The page was responding too slowly. Please try again after a few minutes.
+      html: If you still get this error after a few tries, please %{contact_support_link}.
   feedbacks:
     new:
       abuse:

diff --git a/config/routes.rb b/config/routes.rb
@@ -53,7 +53,7 @@
   get '/422', to: 'errors#422'
   get '/500', to: 'errors#500'
   get '/auth_error', to: 'errors#auth_error'
-  get '/timeout', to: 'errors#timeout'
+  get "/timeout", to: "errors#timeout"
 
   #### DOWNLOADS ####