AO3-6911 Add error page for Rack::Timeout::RequestTimeoutException

[boyer-victor]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6911

Purpose

1. Add a page under /timeout that is returned should the app controller encounter Rack::Timeout::RequestTimeoutException.
2. Added a test that the page is rendered on that route.
3. Added a test that the auth_error page is rendered on its route to errors_controller_spec.rb

Testing Instructions

Needs Systems change, see story for details

I added a unit test that this page can be routed too, but I do not think there is a way to test the actual timeout rescue except from an integration test. See the docs here. If I'm missing something or if we have a method for setting up such tests already that someone could point me too it would be much appreciated.

Credit

unsafe-deref, he/him

[boyer-victor]

I am ignoring the reviewdog comments on single v double quotes as in all instances using single quotes matches the existing page styling or the recommended page to adapt from (re: 500 error page).

[redsummernight]

Please do address the reviewdog comments on the parts that you've added or changed. It's fine to deviate from the existing 500 error page in terms of code style.

You don't have to fix any of the existing lint violations, however.

[Bilka2]

Please also i18n this. Here is an example:

otwarchive/app/controllers/home_controller.rb

Line 16 in 775ed13

@page_subtitle = t(".page_title")

+

otwarchive/config/locales/controllers/en.yml

Line 100 in 775ed13

page_title: Privacy Policy

[boyer-victor]

Thanks! Apologies, I am used to a different pattern and did not look carefully enough at the locale specs for this project. I updated auth_error as well.

[Bilka2]

This needs to have the name of the controller action in the to option, and then lets match the auth_error for the get

Suggested change

	get "/timeout", to: "errors#timeout"
	get "/timeout_error", to: "errors#timeout_error"

The reason the test didn't fail is because by default, even if there is no method in the controller, Rails renders the HTML template with the action name, which is timeout.html.erb. The html.erb should also be renamed to timeout_error.html.erb to match the controller (and the auth error).

[boyer-victor]

Tricky, I would prefer just a failure than a default loading that is non-obvious. Thanks for pointing it out, resolved.