AO3-6922 Update Abuse Form #5075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Bilka2
reviewed
Feb 21, 2025
app/views/abuse_reports/new.html.erb
Outdated
Comment on lines
58
to
59
| <li><%= t(".include.username_html", | ||
| username_link: link_to(t(".include.username"), tos_faq_path(anchor: "user_unknown"))) %></li> |
There was a problem hiding this comment.
I'm slightly worried that the variable, link text and overall sentence all starting with username may be confusing for translators (meaning it's unclear which one is the link text and which one is the sentence). Could username_html maybe be renamed? Best I can come up with is include_username_html.
Same goes for the sources point below, there the three variables also overlap in name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6922
Purpose
Updates Abuse Form text and footnote, adds TOS navigation buttons
Credit
lydia-theda