Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache poetry deps in Github Actions in order to speed up builds #109

Open
atapin opened this issue Jul 4, 2024 · 2 comments
Open

Cache poetry deps in Github Actions in order to speed up builds #109

atapin opened this issue Jul 4, 2024 · 2 comments

Comments

@atapin
Copy link

atapin commented Jul 4, 2024

This can be done by modifying setup python step:

- name: Set up Python
  uses: actions/setup-python@v4
  with:
    python-version: '3.9'
    cache: poetry
    cache-dependency-path: poetry.lock
@atapin
Copy link
Author

atapin commented Jul 5, 2024

Tested this in atapin#1
Surprisingly, there's no profit from caching. But there's 25% speed up if style check and testing are ran inside the same job.

@mattlenz @mattmalec do you think it makes sense to put these steps under the same job? It seems to me, there's no much sense to run tests if style-check is failed. Because if style-check failed and tests succeeded, we couldn't just fix style and assume the test would succeed after this fix.

@atapin
Copy link
Author

atapin commented Jul 5, 2024

Another improvement of CI pipeline, that really should bring benefits to the project is matrix build. For a library, it's important to run builds across different OS's and supported python versions. Let me know if I can help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant