Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for laravel nova 5 #50

Open
zsoltjanes opened this issue Jan 3, 2025 · 3 comments
Open

Missing support for laravel nova 5 #50

zsoltjanes opened this issue Jan 3, 2025 · 3 comments

Comments

@zsoltjanes
Copy link

I have the following error:
Declaration of HasDetachedFilters::availableFilters(Laravel\Nova\Http\Requests\NovaRequest $request) must be compatible with Laravel\Nova\Resource::availableFilters(Laravel\Nova\Http\Requests\NovaRequest $request): Illuminate\Support\Collection

Can you please add to the HasDetachedFilters trait the return type declarations for availableFilters and resolveFilters function.

From:
public function availableFilters(NovaRequest $request)
To:
public function availableFilters(NovaRequest $request): Collection

From:
public function resolveFilters(NovaRequest $request)
From:
public function resolveFilters(NovaRequest $request): Collection

@KasparRosin
Copy link
Member

KasparRosin commented Jan 17, 2025

@zsoltjanes What version of laravel/nova are you using?
If you have a working fix, I'd happily accept a pull request.

@KasparRosin KasparRosin added the bug Something isn't working label Jan 17, 2025
@zsoltjanes
Copy link
Author

Laravel 11.37.0
Nova 5.1.0

@KasparRosin
Copy link
Member

We do not have support for version 5 of laravel/nova yet.

@KasparRosin KasparRosin removed the bug Something isn't working label Jan 24, 2025
@KasparRosin KasparRosin changed the title Declaration problem Missing support for laravel nova 5 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants