Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

Enable admins to manage project status "cul-de-sacs" #182

Closed
justincorrigible opened this issue Jan 19, 2021 · 6 comments
Closed

Enable admins to manage project status "cul-de-sacs" #182

justincorrigible opened this issue Jan 19, 2021 · 6 comments
Assignees

Comments

@justincorrigible
Copy link
Member

justincorrigible commented Jan 19, 2021

image.png

Ticket intended to "undeny", "unapprove", and "unterminate" projects and users.

Caveat: Purged data cannot be restored.

@justincorrigible justincorrigible self-assigned this Jan 20, 2021
@justincorrigible
Copy link
Member Author

justincorrigible commented Jan 28, 2021

Setting up the following admin-only actions, based on Project status (I've already added the ones in bold):

  • Pending:
    • Approve (doesn't send email)
    • Deny (doesn't send email)
    • Should we add something to ignore/terminate application from here optionally sending an email?
  • Approved:
    • "No action needed" currently, replaced with...
    • Terminate (goes to Terminated, after "are you sure?" modal. Currently doesn't send an email, should it?)
  • Termination Request:
    • Confirm (sends email to project owner)
    • Reject (goes back to Approved. Currently, doesn't send email notifying of the rejection, but perhaps should)
  • Terminated/Denied:
    • Purge (after confirmation modal, deletes data and cannot be undone. No email sent)
    • Reopen if Terminated (goes back to Approved. Currently, doesn't send email notifying of the reassessment if Denied, or reopening if Terminated)

@jmimico thoughts about those additions?


Furthermore, perhaps for a separate ticket: do we want to add a UI control to ask admins whether they want to send/skip emailing the users for each action? it may prove useful... I'm thinking of those times we want to change projects' status without sending alarming emails lol ;)

@justincorrigible justincorrigible changed the title Enable admins to manage project/user status "cul-de-sacs" Enable admins to manage project status "cul-de-sacs" Jan 28, 2021
@justincorrigible
Copy link
Member Author

justincorrigible commented Jan 28, 2021

Changed scope of tickets to Projects only. User management to be handled in an existing, much older ticket #7

@b-f-chan
Copy link

b-f-chan commented Feb 3, 2021

@caravinci - I agree, I think the 3 actions you implemented should send e-mails to inform the user, both because it is the right thing to do and for consistency with our other actions. However, want to hear what @jmimico thinks.

Additionally, I don't think I can test these since I am not an Admin on lab-enrolment. I can't see the new action buttons for projects in each of those states :(. Either I will need to be made Admin or @jmimico will need to test this.

@b-f-chan
Copy link

b-f-chan commented Feb 4, 2021

Got admin access and tested in lab:

  • If user requested project termination, admin sees status correctly as "Termination Requested", with Approve and Deny buttons visible
  • If admin approves termination or terminates themselves, status correctly goes to "Terminated"
  • If admin rejects termination request, status correctly goes back to "Approved"
  • In "Terminated" state, Purge and Re-Open actions correctly display
  • If admin re-opens project, status correctly goes back to "Approved"
  • If admin purges project, entry correctly removed from table after confirmation

@jmimico @caravinci - Tested the scope of this ticket (just the bold actions) and it works fine for me. Will let @jmimico test and confirm himself too, but I think it's ready for PR review.

I think we should add the e-mail notifications also, but we can address as separate ticket that @caravinci can pickup later if he needs to move onto other projects after this week.

@jmimico
Copy link

jmimico commented Feb 4, 2021

Tested and appears to work as designed

@justincorrigible
Copy link
Member Author

Splendid. Will open a PR and put it up for review. Thank you both! @b-f-chan @jmimico

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants