diff --git a/.gitignore b/.gitignore index 9ea69976..4d5c6784 100644 --- a/.gitignore +++ b/.gitignore @@ -76,7 +76,7 @@ KeyczarTest.java HelperTest.java DownloadPartRequest.java -# collaboratory +# s3 service.jks application-prod.properties diff --git a/Dockerfile.server b/Dockerfile.server index 45d1e210..8d1f7e12 100644 --- a/Dockerfile.server +++ b/Dockerfile.server @@ -32,6 +32,6 @@ CMD mkdir -p $SCORE_HOME $SCORE_LOGS \ && java -Dlog.path=$SCORE_LOGS \ -jar $JAR_FILE \ --spring.config.location=classpath:/application.yml \ - --spring.profiles.active=amazon,collaboratory,prod,secure + --spring.profiles.active=s3,prod,secure #&& FOR_100_YEARS=$((100*365*24*60*60));while true;do sleep $FOR_100_YEARS;done diff --git a/docker-compose.yml b/docker-compose.yml index ae8525dd..cde27bd5 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -53,7 +53,7 @@ services: dockerfile: "$DOCKERFILE_NAME" target: server environment: - SPRING_PROFILES_ACTIVE: amazon,collaboratory,prod,secure + SPRING_PROFILES_ACTIVE: s3,prod,secure SERVER_PORT: 8080 OBJECT_SENTINEL: heliograph BUCKET_NAME_OBJECT: score.data diff --git a/score-client/src/main/java/bio/overture/score/client/config/ProfileConfig.java b/score-client/src/main/java/bio/overture/score/client/config/ProfileConfig.java index f47e19a3..b2b42c75 100644 --- a/score-client/src/main/java/bio/overture/score/client/config/ProfileConfig.java +++ b/score-client/src/main/java/bio/overture/score/client/config/ProfileConfig.java @@ -27,7 +27,7 @@ public class ProfileConfig { private String endpoint; @Autowired - @Value("${defaultProfile:collaboratory}") + @Value("${defaultProfile:s3}") private String defaultProfile; @Autowired diff --git a/score-client/src/main/resources/application.yml b/score-client/src/main/resources/application.yml index cad66423..996265b9 100644 --- a/score-client/src/main/resources/application.yml +++ b/score-client/src/main/resources/application.yml @@ -71,7 +71,7 @@ token: isTest: false -defaultProfile: collaboratory +defaultProfile: s3 --- diff --git a/score-client/src/test/java/bio/overture/score/client/config/TestProfileConfig.java b/score-client/src/test/java/bio/overture/score/client/config/TestProfileConfig.java index 04cbd9e9..5238a6fd 100644 --- a/score-client/src/test/java/bio/overture/score/client/config/TestProfileConfig.java +++ b/score-client/src/test/java/bio/overture/score/client/config/TestProfileConfig.java @@ -10,7 +10,7 @@ public class TestProfileConfig { @Autowired - @Value("${defaultProfile:collaboratory}") + @Value("${defaultProfile:s3}") private String defaultProfile; @Bean diff --git a/score-client/src/test/resources/application.yml b/score-client/src/test/resources/application.yml index 537c3611..962bbc31 100644 --- a/score-client/src/test/resources/application.yml +++ b/score-client/src/test/resources/application.yml @@ -70,7 +70,7 @@ token: isTest: true -defaultProfile: collaboratory +defaultProfile: s3 --- ############################################################################### diff --git a/score-core/src/main/java/bio/overture/score/core/model/StorageProfiles.java b/score-core/src/main/java/bio/overture/score/core/model/StorageProfiles.java index 0fd86d2a..93cbe713 100644 --- a/score-core/src/main/java/bio/overture/score/core/model/StorageProfiles.java +++ b/score-core/src/main/java/bio/overture/score/core/model/StorageProfiles.java @@ -5,7 +5,7 @@ public enum StorageProfiles { AZURE("azure", "az"), - COLLABORATORY("collaboratory", "s3"); + S3("s3", "s3"); private final String profileKey; private final String profileValue; diff --git a/score-server/src/main/conf/application.properties b/score-server/src/main/conf/application.properties index 720c51d3..7b331d4e 100644 --- a/score-server/src/main/conf/application.properties +++ b/score-server/src/main/conf/application.properties @@ -22,4 +22,4 @@ # s3.secretKey= # server.ssl.key-store-password= # s3.masterEncryptionKeyId= -# collaboratory.bucket.name= \ No newline at end of file +# s3.bucket.name= \ No newline at end of file diff --git a/score-server/src/main/java/bio/overture/score/server/repository/UploadCleanupService.java b/score-server/src/main/java/bio/overture/score/server/repository/UploadCleanupService.java index b7c47d82..940db9f8 100644 --- a/score-server/src/main/java/bio/overture/score/server/repository/UploadCleanupService.java +++ b/score-server/src/main/java/bio/overture/score/server/repository/UploadCleanupService.java @@ -40,10 +40,10 @@ public class UploadCleanupService { /** Configuration. */ - @Value("${collaboratory.data.directory}") + @Value("${s3.data.directory}") private String dataDir; - @Value("${collaboratory.upload.expiration}") + @Value("${s3.upload.expiration}") private int expiration; /** Dependencies. */ diff --git a/score-server/src/main/java/bio/overture/score/server/repository/azure/AzureURLGenerator.java b/score-server/src/main/java/bio/overture/score/server/repository/azure/AzureURLGenerator.java index e68f0c51..cf308381 100644 --- a/score-server/src/main/java/bio/overture/score/server/repository/azure/AzureURLGenerator.java +++ b/score-server/src/main/java/bio/overture/score/server/repository/azure/AzureURLGenerator.java @@ -49,7 +49,7 @@ public class AzureURLGenerator implements URLGenerator { @Value("${bucket.policy.download}") private String downloadPolicy; - @Value("${collaboratory.download.expiration}") + @Value("${s3.download.expiration}") private int expiration; @Autowired private CloudBlobContainer azureContainer; diff --git a/score-server/src/main/java/bio/overture/score/server/repository/s3/S3DownloadService.java b/score-server/src/main/java/bio/overture/score/server/repository/s3/S3DownloadService.java index 2909c005..f93894af 100644 --- a/score-server/src/main/java/bio/overture/score/server/repository/s3/S3DownloadService.java +++ b/score-server/src/main/java/bio/overture/score/server/repository/s3/S3DownloadService.java @@ -70,10 +70,10 @@ public class S3DownloadService implements DownloadService { private static final String PUBLISHED_ANALYSIS_STATE = "PUBLISHED"; /** Configuration. */ - @Value("${collaboratory.data.directory}") + @Value("${s3.data.directory}") private String dataDir; - @Value("${collaboratory.download.expiration}") + @Value("${s3.download.expiration}") private int expiration; @Value("${object.sentinel}") @@ -210,7 +210,7 @@ public ObjectSpecification download( private String getObjectMd5(ObjectMetadata metadata) { val contentMd5 = metadata.getContentMD5(); if (contentMd5 != null) { - return MD5s.toHex(contentMd5); + return MD5s.toHex(contentMd5); } val userMetadataMd5 = metadata.getUserMetaDataOf(s3config.getCustomMd5Property()); // get literal from config diff --git a/score-server/src/main/java/bio/overture/score/server/repository/s3/S3ListingService.java b/score-server/src/main/java/bio/overture/score/server/repository/s3/S3ListingService.java index 22caf5f3..93ee7b40 100644 --- a/score-server/src/main/java/bio/overture/score/server/repository/s3/S3ListingService.java +++ b/score-server/src/main/java/bio/overture/score/server/repository/s3/S3ListingService.java @@ -48,14 +48,9 @@ public class S3ListingService implements ListingService { @Value("${bucket.name.object}") private String bucketName; - @Value("${collaboratory.data.directory}") + @Value("${s3.data.directory}") private String dataDir; - // @Value("${collaboratory.bucket.poolsize}") - // private int bucketPoolSize; - // @Value("${collaboratory.bucket.keysize}") - // private int bucketKeySize; - /** Dependencies. */ @Autowired private AmazonS3 s3; diff --git a/score-server/src/main/java/bio/overture/score/server/repository/s3/S3UploadService.java b/score-server/src/main/java/bio/overture/score/server/repository/s3/S3UploadService.java index 8abaedb8..7cbad788 100644 --- a/score-server/src/main/java/bio/overture/score/server/repository/s3/S3UploadService.java +++ b/score-server/src/main/java/bio/overture/score/server/repository/s3/S3UploadService.java @@ -62,10 +62,10 @@ public class S3UploadService implements UploadService { private static final String UNPUBLISHED_ANALYSIS_STATE = "UNPUBLISHED"; /** Configuration. */ - @Value("${collaboratory.data.directory}") + @Value("${s3.data.directory}") private String dataDir; - @Value("${collaboratory.upload.expiration}") + @Value("${s3.upload.expiration}") private int expiration; @Value("${metadata.useLegacyMode:false}") diff --git a/score-server/src/main/java/bio/overture/score/server/repository/s3/S3UploadStateStore.java b/score-server/src/main/java/bio/overture/score/server/repository/s3/S3UploadStateStore.java index b4cf2840..16f9e972 100644 --- a/score-server/src/main/java/bio/overture/score/server/repository/s3/S3UploadStateStore.java +++ b/score-server/src/main/java/bio/overture/score/server/repository/s3/S3UploadStateStore.java @@ -76,10 +76,10 @@ public class S3UploadStateStore implements UploadStateStore { private static final ObjectMapper MAPPER = new ObjectMapper(); /** Configuration. */ - @Value("${collaboratory.data.directory}") + @Value("${s3.data.directory}") private String dataDir; - @Value("${collaboratory.upload.directory}") + @Value("${s3.upload.directory}") private String uploadDir; /** Dependencies. */ diff --git a/score-server/src/main/resources/application.yml b/score-server/src/main/resources/application.yml index eec5b4ae..c6f2d68a 100644 --- a/score-server/src/main/resources/application.yml +++ b/score-server/src/main/resources/application.yml @@ -33,6 +33,9 @@ server: s3: secured: true sigV4Enabled: true + upload.directory: upload + upload.expiration: 6 + data.directory: data # custom meta property with md5 hash, unused when upload state files are available (default behaviour) # customMd5Property: md5chksum @@ -56,12 +59,6 @@ bucket: object: sentinel: heliograph - -collaboratory: - upload.directory: upload - upload.expiration: 6 - data.directory: data - # COL-131: Change pre-signed URLs TTL to 1 day max download.expiration: 1