You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "SKIN" object will have "metadata": {"model": "slim"} if the player model has slim arms. For square arms, "metadata" will be missing.
Seeing that there is currently only get_skin_url(), I'd say that avatar.py requires a tiny bit of refactoring to not only retrieve the URL but also "metadata" if present so create_av_from_skin() can use different image coordinates for slim skins.
The text was updated successfully, but these errors were encountered:
This branch also (hopefully?) fixes some of the arm and leg textures apparently using the wrong coordinates. I used the updated reference textures from the Minecraft wiki.
Since I'm on Windows, I couldn't get the whole docker thing running so I wasn't able to test these changes myself.
I'd be happy if someone could do a review and maybe even test the changes, especially with regards to image coordinates to make sure that everything lines up properly.
avatar.py
doesn't currently support slim player skins which causes the wrong parts of the texture to be used to render player icons.Example:
The API documentation states:
Seeing that there is currently only
get_skin_url()
, I'd say thatavatar.py
requires a tiny bit of refactoring to not only retrieve the URL but also"metadata"
if present socreate_av_from_skin()
can use different image coordinates for slim skins.The text was updated successfully, but these errors were encountered: