fix(mrc): fix <TileBlock /> #14924
Open
fix(mrc): fix <TileBlock /> #14924
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix layout - use <OdsText /> for label ref: 14917 Signed-off-by: Romain Jamet <[email protected]>
rjamet-ovh
requested review from
stif59100,
aboungnaseng-ovhcloud,
sidlynx and
frenautvh
3 tasks
|
chipp972
approved these changes
Jan 15, 2025
pauldkn
approved these changes
Jan 15, 2025
tibs245
approved these changes
Jan 15, 2025
anooparveti
requested changes
Jan 16, 2025
Comment on lines
+13
to
+16
| <div className="flex flex-col gap-1"> | ||
| <OdsText preset={ODS_TEXT_PRESET.heading6}>{label}</OdsText> | ||
| {children} | ||
| </div> |
There was a problem hiding this comment.
nitpick: Retaining the dl dt dd format is good imo as it provides the necessary accessibility https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl and in fact it's ties the label to the information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developOnly FR translations have been updatedBreaking change is mentioned in relevant commitsDescription