Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCM support #701

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Add OCM support #701

wants to merge 30 commits into from

Conversation

d7oc
Copy link
Contributor

@d7oc d7oc commented Aug 29, 2024

Description

This PR adds OCM support.

Related Issue

Motivation and Context

Feature request

How Has This Been Tested?

Go to deployments/ocm-install, execute helmfile sync. Log in to the two systems, select app "ScienceMesh" and create a share on one system and add the invitation to the other system.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

- added persistant volume (RWO only)
- added configmap with configurable providers
- added OCIS_ENABLE_OCM to fronend and graph services
- added deployment example
- added OCM_JWT_SECRET
@d7oc
Copy link
Contributor Author

d7oc commented Oct 8, 2024

Update PR to lastest main.

@d7oc d7oc marked this pull request as ready for review October 9, 2024 09:01
- added working example deployment
@d7oc
Copy link
Contributor Author

d7oc commented Oct 9, 2024

Working now. Ready for review.

charts/ocis/values.yaml Outdated Show resolved Hide resolved
charts/ocis/values.yaml Outdated Show resolved Hide resolved
charts/ocis/values.yaml Show resolved Hide resolved
charts/ocis/values.yaml Outdated Show resolved Hide resolved
charts/ocis/values.yaml Outdated Show resolved Hide resolved
charts/ocis/templates/ocm/deployment.yaml Outdated Show resolved Hide resolved
charts/ocis/templates/ocm/deployment.yaml Show resolved Hide resolved
charts/ocis/templates/NOTES.txt Show resolved Hide resolved
deployments/ocm-install/helmfile.yaml Outdated Show resolved Hide resolved
charts/ocis/docs/values-desc-table.adoc Show resolved Hide resolved
@wkloucek
Copy link
Contributor

Looks to me like OCM invitations are stored in-memory: owncloud/ocis#10354

@butonic is that true?

@wkloucek
Copy link
Contributor

Also I couldn't find out what's wrong when setting OCM_OCM_PROVIDER_AUTHORIZER_VERIFY_REQUEST_HOSTNAME to true, see owncloud/ocis#10355

@wkloucek
Copy link
Contributor

Looks to me like OCM invitations are stored in-memory: owncloud/ocis#10354

fixed by enabling persistence in the deployment example: fb4b91b

@wkloucek
Copy link
Contributor

I couldn't even do basic testing beyond sharing files: owncloud/ocis#10358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCM support
5 participants