Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Productize app tokens for service integration #10292

Open
butonic opened this issue Oct 14, 2024 · 3 comments
Open

Productize app tokens for service integration #10292

butonic opened this issue Oct 14, 2024 · 3 comments

Comments

@butonic
Copy link
Member

butonic commented Oct 14, 2024

We have an initial implementation for app tokens, but it is disabled by default and marked as experimental.

App tokens are intended to be generated by end users so they can integrate legacy tools that do not support OIDC. However, the current implementation cannot scope the token which is one of the reasons why we marked this as experimental.

There is another use case that we can productize already. The admin can generate app tokens for system accounts used by external services that can then interact with the graph api, e.g. to manage space membership.

The latter does not need to expose the token generation endpoint, as only admins can generate tokens. A PR for the helm chart that adds this as a feature is in owncloud/ocis-charts#767

@butonic
Copy link
Member Author

butonic commented Oct 14, 2024

cc @tbsbdr @dragotin @micbar @wkloucek

The code to support this scope / use case is implemented and documented but needs a security review.

@tbsbdr
Copy link
Contributor

tbsbdr commented Oct 16, 2024

@micbar @dragotin I consider app tokens to be extremely important. I propose to scope app tokens for the next qa-sprint (from what we know as of today: do we still need development or solely security-qa?) do you agree to scope app tokens in the next sprint?

@micbar
Copy link
Contributor

micbar commented Oct 21, 2024

  • Needs a security review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Prio 2
Development

No branches or pull requests

3 participants