Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Protected Folders #12039

Open
kobergj opened this issue Dec 16, 2024 · 8 comments
Open

Password Protected Folders #12039

kobergj opened this issue Dec 16, 2024 · 8 comments
Assignees
Labels
Category:Enhancement Add new functionality

Comments

@kobergj
Copy link
Contributor

kobergj commented Dec 16, 2024

New menu point below New Folder called New Password Protected Folder

  • On click:

    • Open Dialog that allows setting Foldername and Password
    • OPTIONAL: Allow configuring the permissions on the public link
    • Create a folder in the users personal space .PasswordProtectedFolders/projects/<space_name>/<path>/<to>/<folder>
    • Create a public link to this folder with the given password an view permissions (or the configured permissions)
    • Create a .url (?) file that points to the public link
    • Either use .ppf.url extension or a custom one
  • On clicking the .url file:

    • Open the .url file in a splash screen.
  • On delete of .url file the public link and the hidden folder will also be deleted.

  • No other actions available on the .url file.

@LukasHirt LukasHirt self-assigned this Dec 16, 2024
@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Dec 17, 2024
@LukasHirt
Copy link
Collaborator

LukasHirt commented Dec 17, 2024

Rough estimate:

  • create new app: 2
  • extend extensions system to allow passing create folder actions: 5
  • displaying dialog with folder name, password and link permissions: 3
    - choice of permission missing
  • creating the hidden folder, .ppf.url file and public link: 5
    - extension is called .psec
  • open folder in a popup: 3
  • delete .ppf.url file together with the hidden folder and the public link: 2
    - what happens on deletion of file from other room members needs to be clarified
    - Outcome: We don't care. Link gets created. Folder needs to be deleted manually.
  • hide file extension and actions other than delete on the .ppf.url file: 3

@LukasHirt
Copy link
Collaborator

@dj4oC you showed us in the call opening the "splash screen" from some other action. Could you pls let me know what action it was? I tried to find it in the UI but has not been successful.

@dj4oC
Copy link

dj4oC commented Dec 18, 2024

Screenshot 2024-12-10_New Screenshot 2024-12-10_New2

Screenshot 2024-11-15 at 14 22 23

Screenshot 2024-11-11 at 15 23 04

@dj4oC
Copy link

dj4oC commented Dec 18, 2024

@dj4oC you showed us in the call opening the "splash screen" from some other action. Could you pls let me know what action it was? I tried to find it in the UI but has not been successful.

The three dots when you have an document open as shown in the last screenshot

@LukasHirt LukasHirt moved this from Qualification to In progress in Infinite Scale Team Board Jan 14, 2025
@LukasHirt
Copy link
Collaborator

LukasHirt commented Jan 15, 2025

OPTIONAL: Allow configuring the permissions on the public link

I was now checking the link permissions on a folder and it feels like only the "Can edit" permission really makes sense here anyway?

Image

@dj4oC
Copy link

dj4oC commented Jan 20, 2025

OPTIONAL: Allow configuring the permissions on the public link

I was now checking the link permissions on a folder and it feels like only the "Can edit" permission really makes sense here anyway?

Image

Can read can make sense too if the solution of a riddle has been protected. The other pupils should not change the content of the target file

@LukasHirt
Copy link
Collaborator

@kobergj do we consider this a core app? I.e. should it live directly in web repo or in web-extensions repo? I started working on this in web-extensions but now when I am thinking about it, it might be the wrong place? So far it's only in a PR there so it would be really easy to move owncloud/web-extensions#130

@LukasHirt
Copy link
Collaborator

Agreed to move this into web repo just to simplify it and not wait for release of web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
Status: In progress
Development

No branches or pull requests

3 participants