Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG file fails to load after editing linked share password in web 11.1.1, causing infinite loading loop #12106

Closed
anon-pradip opened this issue Jan 16, 2025 · 5 comments · Fixed by #12112
Assignees
Labels
Type:Bug Something isn't working

Comments

@anon-pradip
Copy link
Contributor

anon-pradip commented Jan 16, 2025

Describe the bug

In Web UI 11.0.6, PNG files load correctly after editing the password of a linked share. However, in version Web UI 11.1.1, after editing the password of a public link share and refreshing the page on the sharee side, the page gets stuck in an infinite loading loop when attempting to access the shared file. This issue prevents the PNG file from being displayed, despite entering the correct new password.

Steps to reproduce

  1. user Alice uploads a png file file.png
  2. Alice creates a public link for that file with a password
  3. public opens that link in the incognito tab
  4. Alice edits the link with a new password
  5. public refreshes the page and enters a new password

Expected behavior

The png file should be opened correctly like as in ocis-7.0.0:

deleting-share-link-ocis-7000.webm

Actual behavior

In ocis-7.1.0-rc.1, the page gets stuck in infinite loading state:

infinite-load.for-png-file.webm

Setup

@anon-pradip anon-pradip added the Type:Bug Something isn't working label Jan 16, 2025
@anon-pradip anon-pradip transferred this issue from owncloud/ocis Jan 16, 2025
@saw-jan
Copy link
Member

saw-jan commented Jan 16, 2025

^ CC @LukasHirt

@anon-pradip anon-pradip changed the title PNG file fails to load after editing linked share password in ocis-7.1.0-rc.1, causing infinite loading loop PNG file fails to load after editing linked share password in web 11.1.1, causing infinite loading loop Jan 16, 2025
@anon-pradip
Copy link
Contributor Author

anon-pradip commented Jan 16, 2025

Note

For both versions of web: Web UI 11.1.1 and Web UI 11.0.6

For txt file:

  1. user Alice uploads a text file file.txt
  2. Alice creates a public link for that file with a password
  3. public opens that link in the incognito tab
  4. Alice edits the link with a new password
  5. public refreshes the page

Image

@LukasHirt LukasHirt self-assigned this Jan 17, 2025
@LukasHirt
Copy link
Collaborator

@anon-pradip since the issue with txt files seems a bug on its own, could you please create a separate issue for it? THX

@LukasHirt LukasHirt moved this from Qualification to In progress in Infinite Scale Team Board Jan 17, 2025
@LukasHirt
Copy link
Collaborator

This issue has the same error as #12108 Seems that when the user gets redirected to the password screen, the route query is lost causing then the web UI to panic when going back to the preview app after entering the password. It will be fixed with #12112

@anon-pradip
Copy link
Contributor Author

Note

For both versions of web: Web UI 11.1.1 and Web UI 11.0.6

For txt file:

1. user Alice uploads a text file file.txt

2. Alice creates a public link for that file with a password

3. public opens that link in the incognito tab

4. Alice edits the link with a new password

5. public refreshes the page

Image

Made a separate issue for this: #12113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants