From 1bdc4b387248171d2b5e71fcb82ead2f060be169 Mon Sep 17 00:00:00 2001 From: whatdoineed2do/Ray Date: Tue, 12 Dec 2023 13:09:11 +0000 Subject: [PATCH] [scan] cleanup consistencies on write_metadata log messages --- src/library/filescanner.c | 8 ++++---- src/library/filescanner_ffmpeg.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/library/filescanner.c b/src/library/filescanner.c index 6c72edb228..795dea3fd3 100644 --- a/src/library/filescanner.c +++ b/src/library/filescanner.c @@ -1737,7 +1737,7 @@ filescanner_write_metadata(const char *virtual_path, const uint32_t *id, uint32_ mfi = db_file_fetch_byvirtualpath(virtual_path); if (!mfi) { - DPRINTF(E_INFO, L_SCAN, "No known path for local media, (%s) requested for rating write\n", virtual_path); + DPRINTF(E_INFO, L_SCAN, "No known DB entry for media, '%s' to update metadata\n", virtual_path); return -1; } } @@ -1747,14 +1747,14 @@ filescanner_write_metadata(const char *virtual_path, const uint32_t *id, uint32_ mfi = db_file_fetch_byid(*id); if (!mfi) { - DPRINTF(E_LOG, L_SCAN, "No known path for local media, (%d) requested for rating write\n", *id); + DPRINTF(E_INFO, L_SCAN, "No known DB entry for media, '%d' to update metadata\n", *id); return -1; } } if (mfi->data_kind != DATA_KIND_FILE) { - DPRINTF(E_INFO, L_SCAN, "Ignoring non local media (%d/%s is %s) requested for rating write\n", mfi->id, mfi->path, db_data_kind_label(mfi->data_kind)); + DPRINTF(E_INFO, L_SCAN, "Unsupported media (%s) to update metadata on '%s' (id=%d)\n", db_data_kind_label(mfi->data_kind), mfi->path, mfi->id); ret = -1; goto cleanup; } @@ -1765,7 +1765,7 @@ filescanner_write_metadata(const char *virtual_path, const uint32_t *id, uint32_ if (access(mfi->path, W_OK) < 0 || access(inotify_path, W_OK) < 0) { - DPRINTF(E_INFO, L_SCAN, "No permissions to update metadata, skipping %s\n", mfi->path); + DPRINTF(E_WARN, L_SCAN, "No permissions to update metadata on '%s' - skipping\n", mfi->path); ret = 0; goto cleanup; } diff --git a/src/library/filescanner_ffmpeg.c b/src/library/filescanner_ffmpeg.c index f7ba9b24b6..08410fae48 100644 --- a/src/library/filescanner_ffmpeg.c +++ b/src/library/filescanner_ffmpeg.c @@ -994,7 +994,7 @@ filescanner_ffmpeg_write_rating(const struct media_file_info *mfi) break; default: - DPRINTF(E_WARN, L_SCAN, "Unsupported metadata update for 'rating' on '%s' (%s) - skipping\n", mfi->path, avcodec_get_name(ctx->streams[i]->codecpar->codec_id)); + DPRINTF(E_WARN, L_SCAN, "Unsupported metadata (%s) update for 'rating' on '%s' - skipping\n", avcodec_get_name(ctx->streams[i]->codecpar->codec_id), mfi->path); } }