Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.github.com #444

Open
jayvdb opened this issue Apr 27, 2023 · 2 comments
Open

api.github.com #444

jayvdb opened this issue Apr 27, 2023 · 2 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Apr 27, 2023

When I fetch the latest from https://github.com/github/rest-api-description (it has the same version but it is not the same api), I encounter the following five parse errors. yes, there are only five.

  1. fails in typify schemas_mutually_exclusive due to this field.
"conditions": {
            "anyOf": [
              {
                "$ref": "#/components/schemas/repository-ruleset-conditions"
              },
              {
                "$ref": "#/components/schemas/org-ruleset-conditions"
              }
            ]
          },
  1. /markdown/raw handles two media types , text/plain and text/x-markdown .
  2. Fails due to this:
"422": {
            "description": "Validation failed",
            "content": {
              "application/json": {
                "schema": {
                  "oneOf": [
                    {
                      "$ref": "#/components/schemas/validation-error"
                    },
                    {
                      "$ref": "#/components/schemas/validation-error-simple"
                    }
                  ]
                }
              }
            }
          },
  1. Fails due to this
                  "make_latest": {
                    "type": "string",
                    "description": "Specifies whether this release should be set as the latest release for the repository. Drafts and prereleases cannot be set as latest. Defaults to `true` for newly published releases. `legacy` specifies that the latest release should be determined based on the release creation date and higher semantic version.",
                    "enum": [
                      "true",
                      "false",
                      "legacy"
                    ],
                    "default": true
                  },
  1. response_types.len() <= 1', progenitor-impl/src/method.rs:1171:9 Multiple response types not supported #344
@jayvdb
Copy link
Contributor Author

jayvdb commented Apr 27, 2023

Looks like this overlaps with #395

@augustuswm
Copy link
Contributor

I believe all of these are covered in #395, except for maybe the first one. Can you add any details (and the build errors) to the tracking ticket and I'll update the list of issues for building a GitHub client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants