Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Webinterface] Fix code climate suggestions once fully migrated to streams #182

Open
AaronVasquez opened this issue Jun 27, 2018 · 3 comments
Open

[Webinterface] Fix code climate suggestions once fully migrated to streams #182

AaronVasquez opened this issue Jun 27, 2018 · 3 comments
Assignees
@AaronVasquez

Comments

@AaronVasquez
Copy link
Contributor

The recommendations will go away once the old code is deleted. It's not worth "refactoring" until then.
@AaronVasquez AaronVasquez self-assigned this Jun 27, 2018
@jfarago
Copy link
Contributor

jfarago commented Jun 29, 2018

I want to take a look at configuring the reporting on the other projects too, code climate seems to show "false positives"

@jfarago
Copy link
Contributor

jfarago commented Jul 2, 2018

@AaronVasquez can you link a report with errors we want to ignore?

@AaronVasquez
Copy link
Contributor Author

https://codeclimate.com/github/oysterprotocol/webinterface/pull/183

I think the long functions thing is too restrictive. Especially since a reducer will be long due to matching a bunch of actions.

@pzhao5 can you link to which golang rules you think are too strict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AaronVasquez AaronVasquez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AaronVasquez @jfarago