Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Travis build for TS warnings #189

Open
jfarago opened this issue Jul 3, 2018 · 0 comments
Open

Fail Travis build for TS warnings #189

jfarago opened this issue Jul 3, 2018 · 0 comments

Comments

@jfarago
Copy link
Contributor

jfarago commented Jul 3, 2018

Implement on all three repos

  • webinterface
  • webnode
  • datamap-generator

There are warnings that show up in the console when we dev that are being committed. We want to fail the build to ensure our code remains clean.

I have attached an example some common warnings that show up in eslint. Two of these warning are importing entire libraries that are not being used.

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant