Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect way of prunning the retransmission queue. #38

Open
QUICTester opened this issue Aug 28, 2023 · 2 comments
Open

Incorrect way of prunning the retransmission queue. #38

QUICTester opened this issue Aug 28, 2023 · 2 comments

Comments

@QUICTester
Copy link

Hi,
During testing commit 841c822, we discovered that the PQUIC server uses Picoquic code that does not correctly prune the retransmission queue in picoquic/sender.c:picoquic_implicit_handshake_ack().

The pruning direction on the retransmission queue is opposite to how the packets are added in picoquic/sender.c:picoquic_queue_for_retransmit().

Therefore the picoquic_packet_t* p_next = p->next_packet; in picoquic/sender.c:picoquic_implicit_handshake_ack() should be picoquic_packet_t* p_next = p->previous_packet;

@IoniaSpirit IoniaSpirit mentioned this issue Sep 5, 2023
@mpiraux
Copy link
Member

mpiraux commented Oct 4, 2023

Could you test #39 as a potential fix ?

@QUICTester
Copy link
Author

Yes, it does not have any problem anymore when we test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants