Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove showNoResultsComponent #107

Open
dirkcuys opened this issue Sep 17, 2024 · 1 comment
Open

Remove showNoResultsComponent #107

dirkcuys opened this issue Sep 17, 2024 · 1 comment

Comments

@dirkcuys
Copy link
Member

dirkcuys commented Sep 17, 2024

The variable isn't used in BrowseLearningCircles. If you wish to disable it, you can simply pass an empty fragment as the NoResultsComponent:

const NoNoResultsComponent = props => <></>
@dirkcuys
Copy link
Member Author

Or figure out what happened to it?
Seems like it was initialized based on how the search page is used: https://github.com/p2pu/p2pu-components/blob/master/src/Search/SearchProvider.jsx#L164

But it doesn't actually get used: https://github.com/p2pu/p2pu-components/blob/master/src/Search/SearchProvider.jsx#L176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant