Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add op= assignments #1359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add op= assignments #1359

wants to merge 1 commit into from

Conversation

ChrisDodd
Copy link
Contributor

@ChrisDodd ChrisDodd commented Jan 30, 2025 •
edited
Loading

For #1144

@ChrisDodd ChrisDodd requested a review from jafingerhut January 30, 2025 01:53
jafingerhut
jafingerhut approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably best to let one of the co-chairs do final approval and merging, rather than merging with only my approval.

vlstill
vlstill requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@vlstill vlstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest question to me is what to do with booleans. And we should be careful to specify which operators apply here, not all binary operators are usable.

@vlstill vlstill mentioned this pull request Feb 3, 2025
Open
9 tasks
@ChrisDodd
Add op= assignments
178029a 
Signed-off-by: Chris Dodd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlstill vlstill vlstill requested changes

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisDodd @jafingerhut @vlstill