Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication and split deploy role #596

Open
2 tasks
majamassarini opened this issue Sep 16, 2024 · 0 comments
Open
2 tasks

Remove duplication and split deploy role #596

majamassarini opened this issue Sep 16, 2024 · 0 comments
Labels
complexity/single-task Regular task, should be done within days. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. kind/refactor Technical debt - the code needs love.

Comments

@majamassarini
Copy link
Member

majamassarini commented Sep 16, 2024 •
edited
Loading

After #581 a new deploy role exists.

It was needed to be able to customize the variables in the deploy playbook when running inside tmt.

  • We should get rid of the duplication.
    The deploy playbook and the role are now the very same (the role has handlers, tasks and variables splitted in different files).

  • We agreed also on splitting the new role in multiple smaller roles
@majamassarini majamassarini added complexity/single-task Regular task, should be done within days. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. labels Sep 16, 2024
@majamassarini majamassarini changed the title Remove duplication in deployment playbooks Remove duplication in deploy playbook Sep 16, 2024
@majamassarini majamassarini added the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Sep 16, 2024
@lachmanfrantisek lachmanfrantisek added the kind/refactor Technical debt - the code needs love. label Sep 17, 2024
@majamassarini majamassarini changed the title Remove duplication in deploy playbook Remove duplication and split deploy role Sep 19, 2024
@mfocko mfocko removed the discuss discuss To be discussed within a team (usually on the so-called Architecture meeting next Thursday) label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity/single-task Regular task, should be done within days. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. kind/refactor Technical debt - the code needs love.
Projects
Packit Kanban Board
Status: backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@majamassarini @mfocko @lachmanfrantisek