packit.stg did not accept our result update

[thrix]

Franta Sumsal reported an issue about:

systemd-ci-incubator/systemd#11

Saying

packit-stg/testing-farm-fedora-rawhide-x86_64 Pending — Tests have been submitted ...

But according to our records we sent and update after our testing was completed with an error state:

[11:19:38] [D] https://stg.packit.dev:443 "POST /api/testing-farm/results HTTP/1.1" 200 24
[11:19:38] [D] response content:
---v---v---v---v---v---
"Test results accepted"
---v---v---v---v---v---

Please investigate ... I know this is staging ... but it should still werk

[lachmanfrantisek]

Hi @thrix,

that's weird -- It works well in our testing PR (packit/hello-world#196 (comment)).

But I've merged some bigger changes in our database schema so maybe a related problem to that. I am not working today so will take a look tomorrow. Sorry about that.

[lbarcziova]

I found a corresponding issue in Sentry. We did process the result, but there was raised an exception when we tried to get file from master branch:

GithubException: 404 {"message": "No commit found for the ref master", "documentation_url": "https://docs.github.com/v3/repos/contents/"}

so I assume we wrongly parse the ref.

EDIT: I see that the referenced PR uses fmf_url, so probably we need to fix the parsing of the ref if it is used (therefore our testing PR works fine).

[jpopelka]

I investigated that problem yesterday and found no indicator in the logs about why the check was not updated.

Yes, I also spotted the Sentry issue and initially thought it's the cause, but after that, I realized this issue occurs quite often and it's probably because we do some URL swapping magic (TM) before we submit tests to TF and after we get the results back. So at the moment I think it was not the cause of the not updated check, but I'm not completely sure.

[lbarcziova]

Yes, it happens quite often, not only for this type of issue but for this PR I think it happened all the time or am I wrong?

What I thought was that similarly as here we should use the value for ref from DB , since the commit_sha there is set correctly (whereas from the nested_get(event, "test", "fmf", "ref") we get master which is wrong)

[jpopelka]

Oh yes, you're right!

Do you want to create a PR? I think we just need to move the

            if tft_test_run:
                ref = tft_test_run.commit_sha

outside of the if project_url == TESTING_FARM_INSTALLABILITY_TEST_URL: