Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests require network access #1491

Open
csomh opened this issue May 6, 2022 · 3 comments
Open

Tests require network access #1491

csomh opened this issue May 6, 2022 · 3 comments
Labels
area/general Related to whole service, not a specific part/integration. area/testing Tests are impacted. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.

Comments

@csomh
Copy link
Contributor

csomh commented May 6, 2022

Currently trying to set --network none in make check-in-container causes 65 of the tests to fail (both unit and integration tests), which means, that these tests rely on network access, which means they are prone to failing when an external resource accessed through the network changes its behavior (:wave: Bodhi) or showing false results. With network access one never can be sure that mocks are correct in the tests.

Set --network none in make check-in-container and adjust all the tests to pass without network access.

@TomasTomecek TomasTomecek added the area/testing Tests are impacted. label May 9, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jul 10, 2022
@csomh csomh removed the stale Is the issue still valid? label Jul 11, 2022
@lachmanfrantisek lachmanfrantisek moved this to 📋 Backlog 🔟 in Packit Kanban Board Sep 6, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Sep 21, 2022
@csomh csomh removed the stale Is the issue still valid? label Sep 29, 2022
@lachmanfrantisek lachmanfrantisek added complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. area/general Related to whole service, not a specific part/integration. labels May 10, 2023
@lachmanfrantisek lachmanfrantisek moved this from backlog to priority-backlog in Packit Kanban Board Oct 21, 2024
@lachmanfrantisek
Copy link
Member

Still relevant. Would be nice to fix => putting to priority backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/general Related to whole service, not a specific part/integration. area/testing Tests are impacted. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.
Projects
Status: priority-backlog
Development

No branches or pull requests

3 participants