Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Post-turn Healing and Damage does not Occur in the Proper Order #5127

Open
Snailman11 opened this issue Jan 15, 2025 · 0 comments
Open
Labels
Item Affects an item Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction Refactor Rewriting existing code related

Comments

@Snailman11
Copy link
Collaborator

Snailman11 commented Jan 15, 2025

Describe the bug

End-of-turn damage is determined by the order an effect was applied, with all damage and healing being done at once to the Player before the Opponent.

Reproduction

Use Salt Cure and Leech Seed and notice that the Player's Pokemon is always handled first, and that the order effects activate is entirely dependent on the order they were applied.

	STARTING_LEVEL_OVERRIDE: 30,
	MOVESET_OVERRIDE: [Moves.LEECH_SEED, Moves.SALT_CURE],

	OPP_LEVEL_OVERRIDE: 30,
	OPP_MOVESET_OVERRIDE: [Moves.LEECH_SEED, Moves.SALT_CURE],
	OPP_IVS_OVERRIDE: [31, 0, 31, 0, 0, 0],

	STARTING_HELD_ITEMS_OVERRIDE: [{name: "LEFTOVERS"}],
	OPP_HELD_ITEMS_OVERRIDE: [{name: "LEFTOVERS"}],

Expected behavior

  1. Leech Seed occurs first by order of fastest Pokemon
  2. Trapping, then Salt Cure occurs second by order of fastest Pokemon

https://replay.pokemonshowdown.com/gen9customgame-2281415552

Electrode's health is sapped by Leech Seed!
The opposing Geodude's health is sapped by Leech Seed!

Electrode is hurt by Snap Trap!
Electrode is hurt by Salt Cure!

The opposing Geodude is hurt by Fire Spin!
The opposing Geodude is hurt by Salt Cure!

Full Breakdown of Proper Post-turn Damage Ordering
https://www.smogon.com/forums/threads/sword-shield-battle-mechanics-research.3655528/post-9244179

Screenshots / Videos

Leftovers, Salt Cure and Leech Seed

Leftovers.Salt.Cure.Leech.Seed.mp4

Slower Player Pokemon is affected by Fire Spin then Salt Cure -> Faster Opponent is affected by Salt Cure then Snap Trap
(Opponent should have been affected by Snap Trap before Salt Cure, Opponent should have taken Snap Trap and Salt Cure Damage before the Player)

Order.of.Damage.mp4

Slower Player Pokemon is affected by Salt Cure -> Faster Opponent is affected by Leech Seed then Salt Cure
(Leech Seed should have been the first effect, Opponent should have taken Salt Cure damage first due to speed)

Leech.Seed.Salt.Cure.-.Order.Leech.Seed.Salt.cure.mp4

Session export file

No response

User data export file

No response

Additional context

No response

@Snailman11 Snailman11 added the P2 Bug Minor. Non crashing Incorrect move/ability/interaction label Jan 15, 2025
@Snailman11 Snailman11 changed the title [Bug] Post-turn Healing and Damage does not Occur in the Proper Order. [Bug] Post-turn Healing and Damage does not Occur in the Proper Order Jan 15, 2025
@Snailman11 Snailman11 moved this from To triage to Ready in PokéRogue Bug Management Jan 15, 2025
@Snailman11 Snailman11 added Move Affects a move Item Affects an item Refactor Rewriting existing code related labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Item Affects an item Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction Refactor Rewriting existing code related
Projects
Status: Ready
Development

No branches or pull requests

1 participant