Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] encounter.startOfBattleEffects.push Dancing Lessons and Uncommon Breed Conflate 0th Move with 1st move for Move History #5140

Open
Snailman11 opened this issue Jan 18, 2025 · 0 comments
Labels
Mystery Encounter Mystery Encounters and related work P2 Bug Minor. Non crashing Incorrect move/ability/interaction

Comments

@Snailman11
Copy link
Collaborator

Snailman11 commented Jan 18, 2025

Describe the bug

The Pre-attack move in "Dancing Lessons" and "Uncommon Breed" becomes the Enemy's First turn's move history.
Ex. Enemy Pokemon uses Tackle (0th) -> Enemy Pokemon uses Splash (1st)
The Enemy Pokemon's move used on the 1st turn is considered to be Tackle. It has already acted before the First Turn, on the First Turn

Possibly problematic code, exists in both Uncommon Breed and Dancing Lessons

Link to Discord's Bug Report (Disable not getting right move)
https://discord.com/channels/1125469663833370665/1291463978425516183

Reproduction

Replace the moveset with any move that checks for turndata.acted, and can be used against the Opponent. Notice that the move unexpectedly fails or succeeds, or does or does not do the effect that checks for it.
-Start with Regieleki if checking if the other Pokemon already acted, Start with Shuckle if checking exact move history. Prankster and specific moves on the second turn should read the first turn's move as the 0th move.

	STARTING_WAVE_OVERRIDE: 31,
	STARTING_BIOME_OVERRIDE: Biome.CONSTRUCTION_SITE,
	STARTING_LEVEL_OVERRIDE: 60,

	MOVESET_OVERRIDE: [Moves.SUCKER_PUNCH, Moves.SKETCH, Moves.MIMIC, Moves.COMEUPPANCE],

	MYSTERY_ENCOUNTER_RATE_OVERRIDE: 150,

	MYSTERY_ENCOUNTER_OVERRIDE: MysteryEncounterType.UNCOMMON_BREED,

Expected behavior

The Zeroth Move should exist in move history separate from the First Move.

Screenshots / Videos

Disable always Targets the First (Zeroth) move
Disable.Dancing.mp4
The Enemy has already acted on the First turn

Comeuppance does Damage despite going First
 
https://github.com/user-attachments/assets/cabf1234-4a30-469a-ae72-a6e352ceb64e

Core Enforcer does Damage despite going First

Uncommon.Core.Enforcer.mp4

Sucker Punch Fails

Sucker.mp4
Chloroblast thinks it's been used unsuccessfully
Uncommon.Chloroblast.mp4
Encore targets the 0th move rather than the 1st move

First turn

Uncommon.Encore.mp4

Second Turn (Prankster)

Uncommon.Encore.2nd.Turn.mp4
Copycat Succeeds in copying the correct First turn move.
Copycat.Dancing.NO.mp4

Session export file

No response

User data export file

No response

Additional context

Search for Moves that Use GetlastX, Turndata.acted.

You cannot specify the first move used by a Pokemon using Overrides. It looks for that species' Egg Moves, therefore those must be modified directly, instead.

@Snailman11 Snailman11 added Mystery Encounter Mystery Encounters and related work P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Jan 18, 2025
@Snailman11 Snailman11 moved this from To triage to Ready in PokéRogue Bug Management Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mystery Encounter Mystery Encounters and related work P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
Status: Ready
Development

No branches or pull requests

1 participant