[Bug] encounter.startOfBattleEffects.push Dancing Lessons and Uncommon Breed Conflate 0th Move with 1st move for Move History #5140
Labels
Mystery Encounter
Mystery Encounters and related work
P2 Bug
Minor. Non crashing Incorrect move/ability/interaction
Describe the bug
The Pre-attack move in "Dancing Lessons" and "Uncommon Breed" becomes the Enemy's First turn's move history.
Ex. Enemy Pokemon uses Tackle (0th) -> Enemy Pokemon uses Splash (1st)
The Enemy Pokemon's move used on the 1st turn is considered to be Tackle. It has already acted before the First Turn, on the First Turn
Possibly problematic code, exists in both Uncommon Breed and Dancing Lessons
pokerogue/src/data/mystery-encounters/encounters/uncommon-breed-encounter.ts
Line 169 in ae2c907
Link to Discord's Bug Report (Disable not getting right move)
https://discord.com/channels/1125469663833370665/1291463978425516183
Reproduction
Replace the moveset with any move that checks for turndata.acted, and can be used against the Opponent. Notice that the move unexpectedly fails or succeeds, or does or does not do the effect that checks for it.
-Start with Regieleki if checking if the other Pokemon already acted, Start with Shuckle if checking exact move history. Prankster and specific moves on the second turn should read the first turn's move as the 0th move.
Expected behavior
The Zeroth Move should exist in move history separate from the First Move.
Screenshots / Videos
Disable always Targets the First (Zeroth) move
Disable.Dancing.mp4
The Enemy has already acted on the First turn
Comeuppance does Damage despite going First
https://github.com/user-attachments/assets/cabf1234-4a30-469a-ae72-a6e352ceb64e
Core Enforcer does Damage despite going First
Uncommon.Core.Enforcer.mp4
Sucker Punch Fails
Sucker.mp4
Chloroblast thinks it's been used unsuccessfully
Uncommon.Chloroblast.mp4
Encore targets the 0th move rather than the 1st move
First turn
Uncommon.Encore.mp4
Second Turn (Prankster)
Uncommon.Encore.2nd.Turn.mp4
Copycat Succeeds in copying the correct First turn move.
Copycat.Dancing.NO.mp4
Session export file
No response
User data export file
No response
Additional context
Search for Moves that Use GetlastX, Turndata.acted.
You cannot specify the first move used by a Pokemon using Overrides. It looks for that species' Egg Moves, therefore those must be modified directly, instead.
The text was updated successfully, but these errors were encountered: